From 8a3d00ac025562ee45efae73fcccd0ac3cde0e1e Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 25 Apr 2019 22:55:44 +0200 Subject: [PATCH] GTableView: Double-click should only activate/edit valid indices. --- LibGUI/GTableView.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/LibGUI/GTableView.cpp b/LibGUI/GTableView.cpp index 326b08241c..fbca110db3 100644 --- a/LibGUI/GTableView.cpp +++ b/LibGUI/GTableView.cpp @@ -318,11 +318,14 @@ void GTableView::doubleclick_event(GMouseEvent& event) { if (!model()) return; + auto& model = *this->model(); if (event.button() == GMouseButton::Left) { mousedown_event(event); - if (is_editable()) - begin_editing(model()->selected_index()); - else - model()->activate(model()->selected_index()); + if (model.selected_index().is_valid()) { + if (is_editable()) + begin_editing(model.selected_index()); + else + model.activate(model.selected_index()); + } } }