From 8a3e3503215f993b30412abb12354e11371be265 Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Thu, 15 Jun 2023 12:38:28 +0200
Subject: [PATCH] LibJS/Bytecode: Don't choke on MemberExpression with
 PrivateIdentifier

---
 Userland/Libraries/LibJS/AST.cpp                 | 2 ++
 Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp | 7 ++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Userland/Libraries/LibJS/AST.cpp b/Userland/Libraries/LibJS/AST.cpp
index a234a0066f..9217f7cce5 100644
--- a/Userland/Libraries/LibJS/AST.cpp
+++ b/Userland/Libraries/LibJS/AST.cpp
@@ -3289,6 +3289,8 @@ DeprecatedString MemberExpression::to_string_approximation() const
         object_string = static_cast<Identifier const&>(*m_object).string();
     if (is_computed())
         return DeprecatedString::formatted("{}[<computed>]", object_string);
+    if (is<PrivateIdentifier>(*m_property))
+        return DeprecatedString::formatted("{}.{}", object_string, verify_cast<PrivateIdentifier>(*m_property).string());
     return DeprecatedString::formatted("{}.{}", object_string, verify_cast<Identifier>(*m_property).string());
 }
 
diff --git a/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp b/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
index 9898cac2cc..84981ae6e8 100644
--- a/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
+++ b/Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
@@ -1357,7 +1357,12 @@ Bytecode::CodeGenerationErrorOr<void> CallExpression::generate_bytecode(Bytecode
                 TRY(member_expression.property().generate_bytecode(generator));
                 generator.emit<Bytecode::Op::GetByValue>(this_reg);
             } else {
-                auto identifier_table_ref = generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string());
+                auto identifier_table_ref = [&] {
+                    if (is<PrivateIdentifier>(member_expression.property()))
+                        return generator.intern_identifier(verify_cast<PrivateIdentifier>(member_expression.property()).string());
+                    return generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string());
+                }();
+
                 generator.emit<Bytecode::Op::GetById>(identifier_table_ref);
             }
         }