RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:37:46 +00:00
Code Issues Activity Actions

Everywhere: Stop using NonnullRefPtrVector

Browse source 
This class had slightly confusing semantics and the added weirdness
doesn't seem worth it just so we can say "." instead of "->" when
iterating over a vector of NNRPs.

This patch replaces NonnullRefPtrVector<T> with Vector<NNRP<T>>.
This commit is contained in:
Andreas Kling 2023-03-06 14:17:01 +01:00
parent 104be6c8ac
commit 8a48246ed1
168 changed files with 1280 additions and 1280 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Shell/Formatter.cpp
View file

@ -204,7 +204,7 @@ void Formatter::visit(const AST::BraceExpansion* node)
if (!first)
current_builder().append(',');
first = false;
entry.visit(*this);
entry->visit(*this);
}
}
@ -529,7 +529,7 @@ void Formatter::visit(const AST::ImmediateExpression* node)
for (auto& node : node->arguments()) {
current_builder().append(' ');
node.visit(*this);
node->visit(*this);
}
if (node->has_closing_brace())
@ -585,12 +585,12 @@ void Formatter::visit(const AST::MatchExpr* node)
first_entry = false;
auto first = true;
entry.options.visit(
[&](NonnullRefPtrVector<AST::Node> const& patterns) {
[&](Vector<NonnullRefPtr<AST::Node>> const& patterns) {
for (auto& option : patterns) {
if (!first)
current_builder().append(" | "sv);
first = false;
option.visit(*this);
option->visit(*this);
}
},
[&](Vector<Regex<ECMA262>> const& patterns) {
@ -721,7 +721,7 @@ void Formatter::visit(const AST::Sequence* node)
else
insert_separator();
entry.visit(*this);
entry->visit(*this);
}
visited(node);