RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:57:46 +00:00
Code Issues Activity Actions

LibWeb: Correct types in DOMPoint IDL files, and add FIXMEs

Browse source 
Also, the `w` parameters for the constructor default to 1, not 0.
This commit is contained in:
Sam Atkins 2022-10-05 15:40:31 +01:00 • committed by Linus Groh
parent a6f0508f9f
commit 8a78679152
4 changed files with 23 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Geometry/DOMPoint.h
View file

@ -15,7 +15,7 @@ class DOMPoint final : public DOMPointReadOnly {
WEB_PLATFORM_OBJECT(DOMPoint, DOMPointReadOnly);
public:
static JS::NonnullGCPtr<DOMPoint> construct_impl(JS::Realm&, double x = 0, double y = 0, double z = 0, double w = 0);
static JS::NonnullGCPtr<DOMPoint> construct_impl(JS::Realm&, double x = 0, double y = 0, double z = 0, double w = 1);
virtual ~DOMPoint() override;

14
Userland/Libraries/LibWeb/Geometry/DOMPoint.idl
View file

@ -1,12 +1,16 @@
#import <Geometry/DOMPointReadOnly.idl>
// https://drafts.fxtf.org/geometry/#dompoint
interface DOMPoint : DOMPointReadOnly {
constructor(optional double x = 0, optional double y = 0, optional double z = 0, optional double w = 0);
constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
optional unrestricted double z = 0, optional unrestricted double w = 1);
attribute double x;
attribute double y;
attribute double z;
attribute double w;
// FIXME: [NewObject] static DOMPoint fromPoint(optional DOMPointInit other = {});
inherit attribute unrestricted double x;
inherit attribute unrestricted double y;
inherit attribute unrestricted double z;
inherit attribute unrestricted double w;
};

2
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.h
View file

@ -17,7 +17,7 @@ class DOMPointReadOnly : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(DOMPointReadOnly, Bindings::PlatformObject);
public:
static JS::NonnullGCPtr<DOMPointReadOnly> construct_impl(JS::Realm&, double x = 0, double y = 0, double z = 0, double w = 0);
static JS::NonnullGCPtr<DOMPointReadOnly> construct_impl(JS::Realm&, double x = 0, double y = 0, double z = 0, double w = 1);
virtual ~DOMPointReadOnly() override;

17
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.idl
View file

@ -1,10 +1,17 @@
// https://drafts.fxtf.org/geometry/#dompointreadonly
interface DOMPointReadOnly {
constructor(optional double x = 0, optional double y = 0, optional double z = 0, optional double w = 0);
constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
optional unrestricted double z = 0, optional unrestricted double w = 1);
readonly attribute double x;
readonly attribute double y;
readonly attribute double z;
readonly attribute double w;
// FIXME: [NewObject] static DOMPointReadOnly fromPoint(optional DOMPointInit other = {});
readonly attribute unrestricted double x;
readonly attribute unrestricted double y;
readonly attribute unrestricted double z;
readonly attribute unrestricted double w;
// FIXME: DOMPoint matrixTransform(optional DOMMatrixInit matrix = {});
// FIXME: [Default] object toJSON();
};