From 8a829be25c91c243f274f49cbff2b3851482a5be Mon Sep 17 00:00:00 2001
From: Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
Date: Sun, 25 Feb 2024 10:10:39 +0100
Subject: [PATCH] LibWeb: Handle scenario when Window property setter is called
 on global

This commit fixes a regression introduced in
1528e9109c8f7be7210611309dcc5bfbd40def57.

Turns out that the type of `this_value` in the property setter of the
Window object depends on how the variable is accessed. If the property
is accessed as a global variable, then this_value is of type `Window`.
For example:
```js
performance = null
```

However, when it is accessed as a property of the window object,
`this_value` is of type `WindowProxy`. For example:
```js
window.performance = null
```

This commit updates the window property setters generator to handle
both scenarios.

With this change https://discord.com/login works again.
---
 .../BindingsGenerator/IDLGenerators.cpp       | 23 ++++++++++++++-----
 .../expected/global-performance-property.txt  |  1 +
 .../input/global-performance-property.html    |  9 ++++++++
 3 files changed, 27 insertions(+), 6 deletions(-)
 create mode 100644 Tests/LibWeb/Text/expected/global-performance-property.txt
 create mode 100644 Tests/LibWeb/Text/input/global-performance-property.html

diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
index 9bdce54c0e..d2eb79a7bc 100644
--- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
+++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
@@ -3187,16 +3187,27 @@ JS_DEFINE_NATIVE_FUNCTION(@class_name@::@attribute.setter_callback@)
 }
 )~~~");
         } else if (attribute.extended_attributes.contains("Replaceable"sv)) {
-            if (interface.name.is_one_of("Window")) {
+            if (interface.name == "Window"sv) {
                 attribute_generator.append(R"~~~(
 JS_DEFINE_NATIVE_FUNCTION(@class_name@::@attribute.setter_callback@)
 {
     auto this_value = vm.this_value();
-    if (!this_value.is_object() || !is<WindowProxy>(this_value.as_object()))
-        return vm.throw_completion<JS::TypeError>(JS::ErrorType::NotAnObjectOfType, "@namespaced_name@");
-    auto& window_proxy = static_cast<WindowProxy&>(this_value.as_object());
-    TRY(window_proxy.window()->internal_define_own_property("@attribute.name@", JS::PropertyDescriptor { .value = vm.argument(0), .writable = true }));
-    return JS::js_undefined();
+    JS::GCPtr<Window> window;
+    if (this_value.is_object()) {
+        if (is<WindowProxy>(this_value.as_object())) {
+            auto& window_proxy = static_cast<WindowProxy&>(this_value.as_object());
+            window = window_proxy.window();
+        } else if (is<Window>(this_value.as_object())) {
+            window = &static_cast<Window&>(this_value.as_object());
+        }
+    }
+
+    if (window) {
+        TRY(window->internal_define_own_property("@attribute.name@", JS::PropertyDescriptor { .value = vm.argument(0), .writable = true }));
+        return JS::js_undefined();
+    }
+
+    return vm.throw_completion<JS::TypeError>(JS::ErrorType::NotAnObjectOfType, "@namespaced_name@");
 }
 )~~~");
             } else {
diff --git a/Tests/LibWeb/Text/expected/global-performance-property.txt b/Tests/LibWeb/Text/expected/global-performance-property.txt
new file mode 100644
index 0000000000..7ef22e9a43
--- /dev/null
+++ b/Tests/LibWeb/Text/expected/global-performance-property.txt
@@ -0,0 +1 @@
+PASS
diff --git a/Tests/LibWeb/Text/input/global-performance-property.html b/Tests/LibWeb/Text/input/global-performance-property.html
new file mode 100644
index 0000000000..7641d2f221
--- /dev/null
+++ b/Tests/LibWeb/Text/input/global-performance-property.html
@@ -0,0 +1,9 @@
+<script src="include.js"></script>
+<script>
+    test(() => {
+        // Test passes if this script does not throw an exception.
+        performance;
+        performance = null;
+        println("PASS");
+    });
+</script>