RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 15:57:35 +00:00
Code Issues Activity Actions

LibWeb: Allow percentages for border-radius :^)

Browse source 
During the LengthPercentage split, I converted the individual-corner
`border-foo-bar-radius` properties to LengthPercentage but forgot
`border-radius` itself! Oops. Discord's CSS was doing `border-radius:
50%` a lot, so this cuts down on CSS parser spam.
This commit is contained in:
Sam Atkins 2022-02-07 17:05:15 +00:00 • committed by Andreas Kling
parent 3bf828e0f9
commit 8aaab19e6b
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -3080,8 +3080,8 @@ RefPtr<StyleValue> Parser::parse_border_radius_value(Vector<StyleComponentValueR
RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleComponentValueRule> const& component_values) RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleComponentValueRule> const& component_values)
{ {
auto top_left = [&](Vector<Length>& radii) { return radii[0]; }; auto top_left = [&](Vector<LengthPercentage>& radii) { return radii[0]; };
auto top_right = [&](Vector<Length>& radii) { auto top_right = [&](Vector<LengthPercentage>& radii) {
switch (radii.size()) { switch (radii.size()) {
case 4: case 4:
case 3: case 3:
@ -3093,7 +3093,7 @@ RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleCompo
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
}; };
auto bottom_right = [&](Vector<Length>& radii) { auto bottom_right = [&](Vector<LengthPercentage>& radii) {
switch (radii.size()) { switch (radii.size()) {
case 4: case 4:
case 3: case 3:
@ -3105,7 +3105,7 @@ RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleCompo
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
}; };
auto bottom_left = [&](Vector<Length>& radii) { auto bottom_left = [&](Vector<LengthPercentage>& radii) {
switch (radii.size()) { switch (radii.size()) {
case 4: case 4:
return radii[3]; return radii[3];
@ -3119,8 +3119,8 @@ RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleCompo
} }
}; };
Vector<Length> horizontal_radii; Vector<LengthPercentage> horizontal_radii;
Vector<Length> vertical_radii; Vector<LengthPercentage> vertical_radii;
bool reading_vertical = false; bool reading_vertical = false;
for (auto& value : component_values) { for (auto& value : component_values) {
@ -3132,13 +3132,13 @@ RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(Vector<StyleCompo
continue; continue;
} }
auto maybe_length = parse_length(value); auto maybe_dimension = parse_dimension(value);
if (!maybe_length.has_value()) if (!maybe_dimension.has_value() || !maybe_dimension->is_length_percentage())
return nullptr; return nullptr;
if (reading_vertical) { if (reading_vertical) {
vertical_radii.append(maybe_length.value()); vertical_radii.append(maybe_dimension->length_percentage());
} else { } else {
horizontal_radii.append(maybe_length.value()); horizontal_radii.append(maybe_dimension->length_percentage());
} }
} }