RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:57:36 +00:00
Code Issues Activity Actions

LibWeb: Expose window.self and window.frames

Browse source 
"self" is a way to refer to the global object that will work in both
a window context and a web worker context.

"frames" apparently used to return a list of frame objects according
to MDN, but it now just returns the window object.
This commit is contained in:
Luke 2020-08-31 14:08:10 +01:00 • committed by Andreas Kling
parent 1c8312fa50
commit 8aabec1c94
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -59,6 +59,8 @@ void WindowObject::initialize()
GlobalObject::initialize(); GlobalObject::initialize();
define_property("window", this, JS::Attribute::Enumerable); define_property("window", this, JS::Attribute::Enumerable);
define_property("frames", this, JS::Attribute::Enumerable);
define_property("self", this, JS::Attribute::Enumerable);
define_native_property("document", document_getter, document_setter, JS::Attribute::Enumerable); define_native_property("document", document_getter, document_setter, JS::Attribute::Enumerable);
define_native_function("alert", alert); define_native_function("alert", alert);
define_native_function("confirm", confirm); define_native_function("confirm", confirm);

8
Libraries/LibWeb/Tests/Window/window.window_frames_self.js Normal file
View file

@ -0,0 +1,8 @@
loadPage("file:///res/html/misc/blank.html");
afterInitialPageLoad(() => {
test("window.{window,frames,self} all return the Window object", () => {
expect(window.window).toBe(window.frames);
expect(window.window).toBe(window.self);
});
});