RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

Audio: Fix code smells and issues found by static analysis

Browse source 
This fixes all current code smells, bugs and issues reported by
SonarCloud static analysis. Other issues are almost exclusively false
positives. This makes much code clearer, and some minor benefits in
performance or bug evasion may be gained.
This commit is contained in:
kleines Filmröllchen 2021-11-15 22:27:28 +01:00 • committed by Linus Groh
parent a757f3f421
commit 8af97d0ce7
12 changed files with 99 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibDSP/Track.h
View file

@ -19,7 +19,6 @@ class Track : public Core::Object {
public:
Track(NonnullRefPtr<Transport> transport)
: m_transport(move(transport))
, m_current_signal(Sample {})
{
}
virtual ~Track() override = default;
@ -42,7 +41,7 @@ protected:
NonnullRefPtrVector<Processor> m_processor_chain;
NonnullRefPtr<Transport> m_transport;
// The current signal is stored here, to prevent unnecessary reallocation.
Signal m_current_signal;
Signal m_current_signal { Audio::Sample {} };
};
class NoteTrack final : public Track {
@ -53,7 +52,7 @@ public:
NonnullRefPtrVector<NoteClip> const& clips() const { return m_clips; }
protected:
virtual void compute_current_clips_signal() override;
void compute_current_clips_signal() override;
private:
NonnullRefPtrVector<NoteClip> m_clips;
@ -67,7 +66,7 @@ public:
NonnullRefPtrVector<AudioClip> const& clips() const { return m_clips; }
protected:
virtual void compute_current_clips_signal() override;
void compute_current_clips_signal() override;
private:
NonnullRefPtrVector<AudioClip> m_clips;