RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:07:34 +00:00
Code Issues Activity Actions

Kernel: Avoid unnecessary allocations for TTY::tty_name()

Browse source
This commit is contained in:
Gunnar Beutner 2021-05-12 22:47:06 +02:00 • committed by Andreas Kling
parent 93c3b6bdd2
commit 8b079a6b0d
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/TTY/SlavePTY.cpp
View file

@ -31,7 +31,7 @@ SlavePTY::~SlavePTY()
DevPtsFS::unregister_slave_pty(*this); DevPtsFS::unregister_slave_pty(*this);
} }
String SlavePTY::tty_name() const String const& SlavePTY::tty_name() const
{ {
return m_tty_name; return m_tty_name;
} }

2
Kernel/TTY/SlavePTY.h
View file

@ -26,7 +26,7 @@ public:
private: private:
// ^TTY // ^TTY
virtual String tty_name() const override; virtual String const& tty_name() const override;
virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override; virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
virtual void echo(u8) override; virtual void echo(u8) override;

2
Kernel/TTY/TTY.h
View file

@ -26,7 +26,7 @@ public:
virtual int ioctl(FileDescription&, unsigned request, FlatPtr arg) override final; virtual int ioctl(FileDescription&, unsigned request, FlatPtr arg) override final;
virtual String absolute_path(const FileDescription&) const override { return tty_name(); } virtual String absolute_path(const FileDescription&) const override { return tty_name(); }
virtual String tty_name() const = 0; virtual String const& tty_name() const = 0;
unsigned short rows() const { return m_rows; } unsigned short rows() const { return m_rows; }
unsigned short columns() const { return m_columns; } unsigned short columns() const { return m_columns; }

2
Kernel/TTY/VirtualConsole.h
View file

@ -35,7 +35,7 @@ private:
// ^TTY // ^TTY
virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override; virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
virtual String tty_name() const override { return m_tty_name; } virtual String const& tty_name() const override { return m_tty_name; }
virtual void echo(u8) override; virtual void echo(u8) override;
// ^TerminalClient // ^TerminalClient