mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 08:17:35 +00:00
Everywhere: Pass AK::StringView by value
This commit is contained in:
parent
ad5d217e76
commit
8b1108e485
392 changed files with 978 additions and 978 deletions
|
@ -149,7 +149,7 @@ ErrorOr<void> DevPtsFSInode::flush_metadata()
|
|||
return {};
|
||||
}
|
||||
|
||||
ErrorOr<void> DevPtsFSInode::add_child(Inode&, const StringView&, mode_t)
|
||||
ErrorOr<void> DevPtsFSInode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
@ -159,7 +159,7 @@ ErrorOr<NonnullRefPtr<Inode>> DevPtsFSInode::create_child(StringView, mode_t, de
|
|||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> DevPtsFSInode::remove_child(const StringView&)
|
||||
ErrorOr<void> DevPtsFSInode::remove_child(StringView)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
|
|
@ -54,8 +54,8 @@ private:
|
|||
virtual ErrorOr<void> flush_metadata() override;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& buffer, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
|
||||
|
|
|
@ -85,7 +85,7 @@ ErrorOr<NonnullRefPtr<Inode>> DevTmpFSInode::create_child(StringView, mode_t, de
|
|||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
|
||||
ErrorOr<void> DevTmpFSInode::add_child(Inode&, const StringView&, mode_t)
|
||||
ErrorOr<void> DevTmpFSInode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
|
@ -134,7 +134,7 @@ InodeMetadata DevTmpFSInode::metadata() const
|
|||
return metadata;
|
||||
}
|
||||
|
||||
ErrorOr<void> DevTmpFSInode::remove_child(const StringView&)
|
||||
ErrorOr<void> DevTmpFSInode::remove_child(StringView)
|
||||
{
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
|
@ -233,7 +233,7 @@ ErrorOr<NonnullRefPtr<Inode>> DevTmpFSDirectoryInode::lookup(StringView name)
|
|||
return Error::from_errno(ENOENT);
|
||||
}
|
||||
|
||||
ErrorOr<void> DevTmpFSDirectoryInode::remove_child(const StringView& name)
|
||||
ErrorOr<void> DevTmpFSDirectoryInode::remove_child(StringView name)
|
||||
{
|
||||
MutexLocker locker(m_inode_lock);
|
||||
for (auto& node : m_nodes) {
|
||||
|
|
|
@ -55,8 +55,8 @@ protected:
|
|||
virtual InodeMetadata metadata() const override final;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& buffer, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
virtual ErrorOr<void> truncate(u64) override;
|
||||
|
@ -137,7 +137,7 @@ protected:
|
|||
virtual Type node_type() const override { return Type::Directory; }
|
||||
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> traverse_as_directory(Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)>) const override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> lookup(StringView name) override;
|
||||
DevTmpFSDirectoryInode(DevTmpFS&, NonnullOwnPtr<KString> name);
|
||||
|
|
|
@ -1159,7 +1159,7 @@ ErrorOr<NonnullRefPtr<Inode>> Ext2FSInode::create_child(StringView name, mode_t
|
|||
return fs().create_inode(*this, name, mode, dev, uid, gid);
|
||||
}
|
||||
|
||||
ErrorOr<void> Ext2FSInode::add_child(Inode& child, const StringView& name, mode_t mode)
|
||||
ErrorOr<void> Ext2FSInode::add_child(Inode& child, StringView name, mode_t mode)
|
||||
{
|
||||
MutexLocker locker(m_inode_lock);
|
||||
VERIFY(is_directory());
|
||||
|
@ -1189,7 +1189,7 @@ ErrorOr<void> Ext2FSInode::add_child(Inode& child, const StringView& name, mode_
|
|||
return {};
|
||||
}
|
||||
|
||||
ErrorOr<void> Ext2FSInode::remove_child(const StringView& name)
|
||||
ErrorOr<void> Ext2FSInode::remove_child(StringView name)
|
||||
{
|
||||
MutexLocker locker(m_inode_lock);
|
||||
dbgln_if(EXT2_DEBUG, "Ext2FSInode[{}]::remove_child(): Removing '{}'", identifier(), name);
|
||||
|
|
|
@ -45,8 +45,8 @@ private:
|
|||
virtual ErrorOr<void> flush_metadata() override;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& data, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode& child, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode& child, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> set_atime(time_t) override;
|
||||
virtual ErrorOr<void> set_ctime(time_t) override;
|
||||
virtual ErrorOr<void> set_mtime(time_t) override;
|
||||
|
|
|
@ -42,7 +42,7 @@ FileSystem* FileSystem::from_fsid(u32 id)
|
|||
return nullptr;
|
||||
}
|
||||
|
||||
FileSystem::DirectoryEntryView::DirectoryEntryView(const StringView& n, InodeIdentifier i, u8 ft)
|
||||
FileSystem::DirectoryEntryView::DirectoryEntryView(StringView n, InodeIdentifier i, u8 ft)
|
||||
: name(n)
|
||||
, inode(i)
|
||||
, file_type(ft)
|
||||
|
|
|
@ -46,7 +46,7 @@ public:
|
|||
virtual ErrorOr<void> prepare_to_unmount() { return {}; }
|
||||
|
||||
struct DirectoryEntryView {
|
||||
DirectoryEntryView(const StringView& name, InodeIdentifier, u8 file_type);
|
||||
DirectoryEntryView(StringView name, InodeIdentifier, u8 file_type);
|
||||
|
||||
StringView name;
|
||||
InodeIdentifier inode;
|
||||
|
|
|
@ -512,12 +512,12 @@ ErrorOr<NonnullRefPtr<Inode>> ISO9660Inode::create_child(StringView, mode_t, dev
|
|||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> ISO9660Inode::add_child(Inode&, const StringView&, mode_t)
|
||||
ErrorOr<void> ISO9660Inode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> ISO9660Inode::remove_child(const StringView&)
|
||||
ErrorOr<void> ISO9660Inode::remove_child(StringView)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
@ -556,7 +556,7 @@ void ISO9660Inode::one_ref_left()
|
|||
{
|
||||
}
|
||||
|
||||
ISO9660Inode::ISO9660Inode(ISO9660FS& fs, ISO::DirectoryRecordHeader const& record, StringView const& name)
|
||||
ISO9660Inode::ISO9660Inode(ISO9660FS& fs, ISO::DirectoryRecordHeader const& record, StringView name)
|
||||
: Inode(fs, get_inode_index(record, name))
|
||||
, m_record(record)
|
||||
{
|
||||
|
@ -568,7 +568,7 @@ ISO9660Inode::~ISO9660Inode()
|
|||
{
|
||||
}
|
||||
|
||||
ErrorOr<NonnullRefPtr<ISO9660Inode>> ISO9660Inode::try_create_from_directory_record(ISO9660FS& fs, ISO::DirectoryRecordHeader const& record, StringView const& name)
|
||||
ErrorOr<NonnullRefPtr<ISO9660Inode>> ISO9660Inode::try_create_from_directory_record(ISO9660FS& fs, ISO::DirectoryRecordHeader const& record, StringView name)
|
||||
{
|
||||
return adopt_nonnull_ref_or_enomem(new (nothrow) ISO9660Inode(fs, record, name));
|
||||
}
|
||||
|
@ -651,7 +651,7 @@ StringView ISO9660Inode::get_normalized_filename(ISO::DirectoryRecordHeader cons
|
|||
return { buffer.data(), filename.length() };
|
||||
}
|
||||
|
||||
InodeIndex ISO9660Inode::get_inode_index(ISO::DirectoryRecordHeader const& record, StringView const& name)
|
||||
InodeIndex ISO9660Inode::get_inode_index(ISO::DirectoryRecordHeader const& record, StringView name)
|
||||
{
|
||||
if (name.is_null()) {
|
||||
// NOTE: This is the index of the root inode.
|
||||
|
|
|
@ -354,8 +354,8 @@ public:
|
|||
virtual ErrorOr<void> flush_metadata() override;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& buffer, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
virtual ErrorOr<void> truncate(u64) override;
|
||||
|
@ -370,10 +370,10 @@ private:
|
|||
// without any problems, so let's allow it anyway.
|
||||
static constexpr size_t max_file_identifier_length = 256 - sizeof(ISO::DirectoryRecordHeader);
|
||||
|
||||
ISO9660Inode(ISO9660FS&, ISO::DirectoryRecordHeader const& record, StringView const& name);
|
||||
static ErrorOr<NonnullRefPtr<ISO9660Inode>> try_create_from_directory_record(ISO9660FS&, ISO::DirectoryRecordHeader const& record, StringView const& name);
|
||||
ISO9660Inode(ISO9660FS&, ISO::DirectoryRecordHeader const& record, StringView name);
|
||||
static ErrorOr<NonnullRefPtr<ISO9660Inode>> try_create_from_directory_record(ISO9660FS&, ISO::DirectoryRecordHeader const& record, StringView name);
|
||||
|
||||
static InodeIndex get_inode_index(ISO::DirectoryRecordHeader const& record, StringView const& name);
|
||||
static InodeIndex get_inode_index(ISO::DirectoryRecordHeader const& record, StringView name);
|
||||
static StringView get_normalized_filename(ISO::DirectoryRecordHeader const& record, Bytes buffer);
|
||||
|
||||
void create_metadata();
|
||||
|
|
|
@ -57,8 +57,8 @@ public:
|
|||
virtual ErrorOr<NonnullRefPtr<Inode>> lookup(StringView name) = 0;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& data, OpenFileDescription*) = 0;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) = 0;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) = 0;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) = 0;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) = 0;
|
||||
virtual ErrorOr<void> remove_child(StringView name) = 0;
|
||||
virtual ErrorOr<void> chmod(mode_t) = 0;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) = 0;
|
||||
virtual ErrorOr<void> truncate(u64) { return {}; }
|
||||
|
|
|
@ -112,7 +112,7 @@ public:
|
|||
|
||||
class Decoder {
|
||||
public:
|
||||
explicit Decoder(const StringView& data)
|
||||
explicit Decoder(StringView data)
|
||||
: m_data(data)
|
||||
{
|
||||
}
|
||||
|
@ -144,8 +144,8 @@ public:
|
|||
Message& operator<<(u16);
|
||||
Message& operator<<(u32);
|
||||
Message& operator<<(u64);
|
||||
Message& operator<<(const StringView&);
|
||||
void append_data(const StringView&);
|
||||
Message& operator<<(StringView);
|
||||
void append_data(StringView);
|
||||
|
||||
template<typename T>
|
||||
Message& operator>>(T& t)
|
||||
|
@ -228,7 +228,7 @@ ErrorOr<void> Plan9FS::initialize()
|
|||
return {};
|
||||
}
|
||||
|
||||
Plan9FS::ProtocolVersion Plan9FS::parse_protocol_version(const StringView& s) const
|
||||
Plan9FS::ProtocolVersion Plan9FS::parse_protocol_version(StringView s) const
|
||||
{
|
||||
if (s == "9P2000.L")
|
||||
return ProtocolVersion::v9P2000L;
|
||||
|
@ -262,7 +262,7 @@ Plan9FS::Message& Plan9FS::Message::operator<<(u64 number)
|
|||
return append_number(number);
|
||||
}
|
||||
|
||||
Plan9FS::Message& Plan9FS::Message::operator<<(const StringView& string)
|
||||
Plan9FS::Message& Plan9FS::Message::operator<<(StringView string)
|
||||
{
|
||||
*this << static_cast<u16>(string.length());
|
||||
// FIXME: Handle append failure.
|
||||
|
@ -270,7 +270,7 @@ Plan9FS::Message& Plan9FS::Message::operator<<(const StringView& string)
|
|||
return *this;
|
||||
}
|
||||
|
||||
void Plan9FS::Message::append_data(const StringView& data)
|
||||
void Plan9FS::Message::append_data(StringView data)
|
||||
{
|
||||
*this << static_cast<u32>(data.length());
|
||||
// FIXME: Handle append failure.
|
||||
|
@ -908,13 +908,13 @@ ErrorOr<NonnullRefPtr<Inode>> Plan9FSInode::create_child(StringView, mode_t, dev
|
|||
return ENOTIMPL;
|
||||
}
|
||||
|
||||
ErrorOr<void> Plan9FSInode::add_child(Inode&, const StringView&, mode_t)
|
||||
ErrorOr<void> Plan9FSInode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
// TODO
|
||||
return ENOTIMPL;
|
||||
}
|
||||
|
||||
ErrorOr<void> Plan9FSInode::remove_child(const StringView&)
|
||||
ErrorOr<void> Plan9FSInode::remove_child(StringView)
|
||||
{
|
||||
// TODO
|
||||
return ENOTIMPL;
|
||||
|
|
|
@ -122,7 +122,7 @@ private:
|
|||
ErrorOr<void> post_message_and_wait_for_a_reply(Message&);
|
||||
ErrorOr<void> post_message_and_explicitly_ignore_reply(Message&);
|
||||
|
||||
ProtocolVersion parse_protocol_version(const StringView&) const;
|
||||
ProtocolVersion parse_protocol_version(StringView) const;
|
||||
size_t adjust_buffer_size(size_t size) const;
|
||||
|
||||
void thread_main();
|
||||
|
@ -161,8 +161,8 @@ public:
|
|||
virtual ErrorOr<void> traverse_as_directory(Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)>) const override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> lookup(StringView name) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
virtual ErrorOr<void> truncate(u64) override;
|
||||
|
|
|
@ -75,7 +75,7 @@ ErrorOr<void> ProcFSInode::flush_metadata()
|
|||
return {};
|
||||
}
|
||||
|
||||
ErrorOr<void> ProcFSInode::add_child(Inode&, const StringView&, mode_t)
|
||||
ErrorOr<void> ProcFSInode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
@ -85,7 +85,7 @@ ErrorOr<NonnullRefPtr<Inode>> ProcFSInode::create_child(StringView, mode_t, dev_
|
|||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> ProcFSInode::remove_child(const StringView&)
|
||||
ErrorOr<void> ProcFSInode::remove_child(StringView)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
|
|
@ -58,8 +58,8 @@ protected:
|
|||
virtual void did_seek(OpenFileDescription&, off_t) = 0;
|
||||
virtual ErrorOr<void> flush_metadata() override final;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override final;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override final;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override final;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override final;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override final;
|
||||
virtual ErrorOr<void> chmod(mode_t) override final;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override final;
|
||||
};
|
||||
|
|
|
@ -163,12 +163,12 @@ ErrorOr<NonnullRefPtr<Inode>> SysFSInode::create_child(StringView, mode_t, dev_t
|
|||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> SysFSInode::add_child(Inode&, StringView const&, mode_t)
|
||||
ErrorOr<void> SysFSInode::add_child(Inode&, StringView, mode_t)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
||||
ErrorOr<void> SysFSInode::remove_child(StringView const&)
|
||||
ErrorOr<void> SysFSInode::remove_child(StringView)
|
||||
{
|
||||
return EROFS;
|
||||
}
|
||||
|
|
|
@ -141,8 +141,8 @@ protected:
|
|||
virtual InodeMetadata metadata() const override;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, UserOrKernelBuffer const&, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView const& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView const& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
virtual ErrorOr<void> truncate(u64) override;
|
||||
|
|
|
@ -269,7 +269,7 @@ ErrorOr<NonnullRefPtr<Inode>> TmpFSInode::create_child(StringView name, mode_t m
|
|||
return child;
|
||||
}
|
||||
|
||||
ErrorOr<void> TmpFSInode::add_child(Inode& child, StringView const& name, mode_t)
|
||||
ErrorOr<void> TmpFSInode::add_child(Inode& child, StringView name, mode_t)
|
||||
{
|
||||
VERIFY(is_directory());
|
||||
VERIFY(child.fsid() == fsid());
|
||||
|
@ -289,7 +289,7 @@ ErrorOr<void> TmpFSInode::add_child(Inode& child, StringView const& name, mode_t
|
|||
return {};
|
||||
}
|
||||
|
||||
ErrorOr<void> TmpFSInode::remove_child(StringView const& name)
|
||||
ErrorOr<void> TmpFSInode::remove_child(StringView name)
|
||||
{
|
||||
MutexLocker locker(m_inode_lock);
|
||||
VERIFY(is_directory());
|
||||
|
|
|
@ -59,8 +59,8 @@ public:
|
|||
virtual ErrorOr<void> flush_metadata() override;
|
||||
virtual ErrorOr<size_t> write_bytes(off_t, size_t, const UserOrKernelBuffer& buffer, OpenFileDescription*) override;
|
||||
virtual ErrorOr<NonnullRefPtr<Inode>> create_child(StringView name, mode_t, dev_t, UserID, GroupID) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, const StringView& name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(const StringView& name) override;
|
||||
virtual ErrorOr<void> add_child(Inode&, StringView name, mode_t) override;
|
||||
virtual ErrorOr<void> remove_child(StringView name) override;
|
||||
virtual ErrorOr<void> chmod(mode_t) override;
|
||||
virtual ErrorOr<void> chown(UserID, GroupID) override;
|
||||
virtual ErrorOr<void> truncate(u64) override;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue