RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 05:27:45 +00:00
Code Issues Activity Actions

Everywhere: Pass AK::StringView by value

Browse source
This commit is contained in:
Andreas Kling 2021-11-11 00:55:02 +01:00
parent ad5d217e76
commit 8b1108e485
392 changed files with 978 additions and 978 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/Profiler/Profile.cpp
View file

@ -215,7 +215,7 @@ void Profile::rebuild_tree()
Optional<MappedObject> g_kernel_debuginfo_object;
OwnPtr<Debug::DebugInfo> g_kernel_debug_info;
ErrorOr<NonnullOwnPtr<Profile>> Profile::load_from_perfcore_file(const StringView& path)
ErrorOr<NonnullOwnPtr<Profile>> Profile::load_from_perfcore_file(StringView path)
{
auto file = TRY(Core::File::open(path, Core::OpenMode::ReadOnly));

2
Userland/DevTools/Profiler/Profile.h
View file

@ -141,7 +141,7 @@ struct ProcessFilter {
class Profile {
public:
static ErrorOr<NonnullOwnPtr<Profile>> load_from_perfcore_file(const StringView& path);
static ErrorOr<NonnullOwnPtr<Profile>> load_from_perfcore_file(StringView path);
GUI::Model& model();
GUI::Model& samples_model();

2
Userland/DevTools/Profiler/ProfileModel.cpp
View file

@ -145,7 +145,7 @@ GUI::Variant ProfileModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol
return {};
}
Vector<GUI::ModelIndex> ProfileModel::matches(StringView const& searching, unsigned flags, GUI::ModelIndex const& parent)
Vector<GUI::ModelIndex> ProfileModel::matches(StringView searching, unsigned flags, GUI::ModelIndex const& parent)
{
RemoveReference<decltype(m_profile.roots())>* nodes { nullptr };

2
Userland/DevTools/Profiler/ProfileModel.h
View file

@ -39,7 +39,7 @@ public:
virtual int tree_column() const override { return Column::StackFrame; }
virtual bool is_column_sortable(int) const override { return false; }
virtual bool is_searchable() const override { return true; }
virtual Vector<GUI::ModelIndex> matches(StringView const&, unsigned flags, GUI::ModelIndex const&) override;
virtual Vector<GUI::ModelIndex> matches(StringView, unsigned flags, GUI::ModelIndex const&) override;
private:
explicit ProfileModel(Profile&);