RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 09:27:45 +00:00
Code Issues Activity Actions

Everywhere: Pass AK::StringView by value

Browse source
This commit is contained in:
Andreas Kling 2021-11-11 00:55:02 +01:00
parent ad5d217e76
commit 8b1108e485
392 changed files with 978 additions and 978 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibTLS/HandshakeClient.cpp
View file

@ -140,7 +140,7 @@ bool TLSv12::compute_master_secret_from_pre_master_secret(size_t length)
return true;
}
static bool wildcard_matches(const StringView& host, const StringView& subject)
static bool wildcard_matches(StringView host, StringView subject)
{
if (host.matches(subject))
return true;
@ -151,7 +151,7 @@ static bool wildcard_matches(const StringView& host, const StringView& subject)
return false;
}
Optional<size_t> TLSv12::verify_chain_and_get_matching_certificate(const StringView& host) const
Optional<size_t> TLSv12::verify_chain_and_get_matching_certificate(StringView host) const
{
if (m_context.certificates.is_empty() || !m_context.verify_chain())
return {};

12
Userland/Libraries/LibTLS/TLSv12.h
View file

@ -236,7 +236,7 @@ struct Context {
bool verify() const;
bool verify_chain() const;
static void print_file(const StringView& fname);
static void print_file(StringView fname);
Options options;
@ -318,7 +318,7 @@ public:
bool is_established() const { return m_context.connection_status == ConnectionStatus::Established; }
virtual bool connect(const String&, int) override;
void set_sni(const StringView& sni)
void set_sni(StringView sni)
{
if (m_context.is_server || m_context.critical_error || m_context.connection_status != ConnectionStatus::Disconnected) {
dbgln("invalid state for set_sni");
@ -341,9 +341,9 @@ public:
ByteBuffer finish_build();
const StringView& alpn() const { return m_context.negotiated_alpn; }
void add_alpn(const StringView& alpn);
bool has_alpn(const StringView& alpn) const;
StringView alpn() const { return m_context.negotiated_alpn; }
void add_alpn(StringView alpn);
bool has_alpn(StringView alpn) const;
bool supports_cipher(CipherSuite suite) const
{
@ -508,7 +508,7 @@ private:
bool compute_master_secret_from_pre_master_secret(size_t length);
Optional<size_t> verify_chain_and_get_matching_certificate(const StringView& host) const;
Optional<size_t> verify_chain_and_get_matching_certificate(StringView host) const;
void try_disambiguate_error() const;