RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:47:35 +00:00
Code Issues Activity Actions

LibWeb: Clarify stacking context creation for viewport box

Browse source 
Explicitly check is_viewport() instead of looking at the corresponding
DOM node. (The viewport has the DOM document as its DOM node, but that's
not obvious from context here.)
This commit is contained in:
Andreas Kling 2023-03-18 12:09:22 +01:00
parent 8169b878f8
commit 8b177a6da5
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/Layout/Node.cpp
View file

@ -117,8 +117,15 @@ bool Node::establishes_stacking_context() const
if (!has_style())
return false;
if (is_root_element() || dom_node() == &document().root())
// We make a stacking context for the viewport. Painting and hit testing starts from here.
if (is_viewport())
return true;
// Root element of the document (<html>).
if (is_root_element())
return true;
auto position = computed_values().position();
// Element with a position value absolute or relative and z-index value other than auto.