RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:18:12 +00:00
Code Issues Activity Actions

LibPDF: Reject invalid "hival" values

Browse source 
Doesn't fire on any of the PDFs I have, and seems like a good thing
to check.
This commit is contained in:
Nico Weber 2023-12-06 19:33:29 -05:00 • committed by Sam Atkins
parent 43cd3d7dbd
commit 8b50b689f9
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibPDF/ColorSpace.cpp
View file

@ -649,6 +649,8 @@ PDFErrorOr<NonnullRefPtr<ColorSpace>> IndexedColorSpace::create(Document* docume
// "The hival parameter is an integer that specifies the maximum valid index value. In other words,
// the color table is to be indexed by integers in the range 0 to hival. hival can be no greater than 255"
auto hival = TRY(document->resolve_to<int>(parameters[1]));
if (hival < 0 || hival > 255)
return Error { Error::Type::MalformedPDF, "Indexed color space hival out of range" };
// "The color table is defined by the lookup parameter, which can be either a stream or (in PDF 1.2) a byte string.
// It provides the mapping between index values and the corresponding colors in the base color space.