From 8b5ea01cfb936b8fc2f586d0ea6f94352504ba62 Mon Sep 17 00:00:00 2001 From: Luke Date: Mon, 3 May 2021 02:06:11 +0100 Subject: [PATCH] LibWeb: Use node_to_insert instead of node in Node::insert_before It was using the passed in node instead of the node from the vector. Fixes a crash I found while testing jQuery. --- Userland/Libraries/LibWeb/DOM/Node.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Node.cpp b/Userland/Libraries/LibWeb/DOM/Node.cpp index 93d85754b8..a7484bcb84 100644 --- a/Userland/Libraries/LibWeb/DOM/Node.cpp +++ b/Userland/Libraries/LibWeb/DOM/Node.cpp @@ -232,9 +232,9 @@ void Node::insert_before(NonnullRefPtr node, RefPtr child, bool supp document().adopt_node(node_to_insert); if (!child) - TreeNode::append_child(node); + TreeNode::append_child(node_to_insert); else - TreeNode::insert_before(node, child); + TreeNode::insert_before(node_to_insert, child); // FIXME: If parent is a shadow host and node is a slottable, then assign a slot for node. // FIXME: If parent’s root is a shadow root, and parent is a slot whose assigned nodes is the empty list, then run signal a slot change for parent.