1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:38:13 +00:00

RequestServer: Make value copy of the URL in ensure_connection()

I saw what looked like a UAF of this URL in a RequestServer crash,
and it seems reasonable to make a copy here since we end up passing
them to Core::deferred_invoke().
This commit is contained in:
Andreas Kling 2022-02-12 22:28:22 +01:00
parent 3c108e20a7
commit 8b8a1449c4

View file

@ -126,7 +126,7 @@ void ClientConnection::ensure_connection(URL const& url, ::RequestServer::CacheL
}
struct {
URL const& m_url;
URL m_url;
void start(Core::Stream::Socket& socket)
{
auto is_connected = socket.is_open();