From 8ba7bd1b67f7d028205b541cec4856e7aecc2907 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 26 May 2023 19:08:28 +0200 Subject: [PATCH] LibWeb: Accept fit-content as a value for min-width and max-width This starts working immediately in BFC thanks to calculate_inner_width being used for width constraints. :^) --- .../block-with-fit-content-width-constraints.txt | 15 +++++++++++++++ .../block-with-fit-content-width-constraints.html | 13 +++++++++++++ Userland/Libraries/LibWeb/CSS/Properties.json | 2 ++ 3 files changed, 30 insertions(+) create mode 100644 Tests/LibWeb/Layout/expected/block-and-inline/block-with-fit-content-width-constraints.txt create mode 100644 Tests/LibWeb/Layout/input/block-and-inline/block-with-fit-content-width-constraints.html diff --git a/Tests/LibWeb/Layout/expected/block-and-inline/block-with-fit-content-width-constraints.txt b/Tests/LibWeb/Layout/expected/block-and-inline/block-with-fit-content-width-constraints.txt new file mode 100644 index 0000000000..a7f3280871 --- /dev/null +++ b/Tests/LibWeb/Layout/expected/block-and-inline/block-with-fit-content-width-constraints.txt @@ -0,0 +1,15 @@ +Viewport <#document> at (0,0) content-size 800x600 children: not-inline + BlockContainer at (1,1) content-size 798x56.9375 [BFC] children: not-inline + BlockContainer at (10,10) content-size 780x38.9375 children: not-inline + BlockContainer at (11,11) content-size 138.28125x17.46875 children: inline + line 0 width: 138.28125, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 18, rect: [11,11 138.28125x17.46875] + "Well hello friends" + TextNode <#text> + BlockContainer at (11,30.46875) content-size 138.28125x17.46875 children: inline + line 0 width: 138.28125, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 18, rect: [11,30.46875 138.28125x17.46875] + "Well hello friends" + TextNode <#text> + BlockContainer <(anonymous)> at (10,48.9375) content-size 780x0 children: inline + TextNode <#text> diff --git a/Tests/LibWeb/Layout/input/block-and-inline/block-with-fit-content-width-constraints.html b/Tests/LibWeb/Layout/input/block-and-inline/block-with-fit-content-width-constraints.html new file mode 100644 index 0000000000..3bd245414c --- /dev/null +++ b/Tests/LibWeb/Layout/input/block-and-inline/block-with-fit-content-width-constraints.html @@ -0,0 +1,13 @@ +
Well hello friends
Well hello friends
diff --git a/Userland/Libraries/LibWeb/CSS/Properties.json b/Userland/Libraries/LibWeb/CSS/Properties.json index 05c7f79f83..cc586bf9e6 100644 --- a/Userland/Libraries/LibWeb/CSS/Properties.json +++ b/Userland/Libraries/LibWeb/CSS/Properties.json @@ -1235,6 +1235,7 @@ "percentage [0,∞]" ], "valid-identifiers": [ + "fit-content", "none" ], "quirks": [ @@ -1265,6 +1266,7 @@ ], "valid-identifiers": [ "auto", + "fit-content", "none" ], "quirks": [