RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:57:35 +00:00
Code Issues Activity Actions

AK: Remove Optional::operator bool()

Browse source 
This was causing some obvious-in-hindsight but hard to spot bugs where
we'd implicitly convert the bool to an integer type and carry on with
the number 1 instead of the actual value().
This commit is contained in:
Andreas Kling 2020-03-06 10:26:05 +01:00
parent ae233c1e82
commit 8bb361889c
6 changed files with 9 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Servers/LookupServer/LookupServer.cpp
View file

@ -117,7 +117,7 @@ void LookupServer::service_client(RefPtr<Core::LocalSocket> socket)
Vector<String> responses;
if (auto known_host = m_etc_hosts.get(hostname)) {
if (auto known_host = m_etc_hosts.get(hostname); known_host.has_value()) {
responses.append(known_host.value());
} else if (!hostname.is_empty()) {
bool did_timeout;