diff --git a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h index bf9a9e0279..65c74fe149 100644 --- a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h +++ b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h @@ -263,6 +263,7 @@ namespace JS { P(max) \ P(message) \ P(microseconds) \ + P(millisecond) \ P(milliseconds) \ P(min) \ P(minute) \ diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp index ab02e6dead..d66774aa4f 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp @@ -30,6 +30,7 @@ void PlainTimePrototype::initialize(GlobalObject& global_object) define_native_accessor(vm.names.hour, hour_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.minute, minute_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.second, second_getter, {}, Attribute::Configurable); + define_native_accessor(vm.names.millisecond, millisecond_getter, {}, Attribute::Configurable); u8 attr = Attribute::Writable | Attribute::Configurable; define_native_function(vm.names.valueOf, value_of, 0, attr); @@ -100,6 +101,19 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::second_getter) return Value(temporal_time->iso_second()); } +// 4.3.7 get Temporal.PlainTime.prototype.millisecond, https://tc39.es/proposal-temporal/#sec-get-temporal.plaintime.prototype.millisecond +JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::millisecond_getter) +{ + // 1. Let temporalTime be the this value. + // 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]). + auto* temporal_time = typed_this(global_object); + if (vm.exception()) + return {}; + + // 3. Return 𝔽(temporalTime.[[ISOMillisecond]]). + return Value(temporal_time->iso_millisecond()); +} + // 4.3.23 Temporal.PlainTime.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.valueof JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::value_of) { diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.h index d58afaef13..41a92cd344 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.h @@ -23,6 +23,7 @@ private: JS_DECLARE_NATIVE_FUNCTION(hour_getter); JS_DECLARE_NATIVE_FUNCTION(minute_getter); JS_DECLARE_NATIVE_FUNCTION(second_getter); + JS_DECLARE_NATIVE_FUNCTION(millisecond_getter); JS_DECLARE_NATIVE_FUNCTION(value_of); }; diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.prototype.millisecond.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.prototype.millisecond.js new file mode 100644 index 0000000000..883c8ef4cc --- /dev/null +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.prototype.millisecond.js @@ -0,0 +1,14 @@ +describe("correct behavior", () => { + test("basic functionality", () => { + const plainTime = new Temporal.PlainTime(0, 0, 0, 12); + expect(plainTime.millisecond).toBe(12); + }); +}); + +test("errors", () => { + test("this value must be a Temporal.PlainTime object", () => { + expect(() => { + Reflect.get(Temporal.PlainTime.prototype, "millisecond", "foo"); + }).toThrowWithMessage(TypeError, "Not a Temporal.PlainTime"); + }); +});