RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:27:34 +00:00
Code Issues Activity Actions

LibWeb: Paint non-positioned stacking contexts with z-index 0 or auto

Browse source 
As I understand it, these have to be painted interleaved with positioned
descendants in the same z-index category, in tree order.
This commit is contained in:
Andreas Kling 2022-10-23 20:56:42 +02:00
parent 447519f678
commit 8bf0e71c0c
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -155,17 +155,19 @@ void StackingContext::paint_internal(PaintContext& context) const
paint_descendants(context, m_box, StackingContextPaintPhase::Foreground);
// Draw positioned descendants with z-index `0` or `auto` in tree order. (step 8)
// NOTE: Non-positioned descendants that establish stacking contexts with z-index `0` or `auto` are also painted here.
// FIXME: There's more to this step that we have yet to understand and implement.
m_box.paint_box()->for_each_in_subtree_of_type<PaintableBox>([&](PaintableBox const& paint_box) {
if (!paint_box.layout_box().is_positioned())
return TraversalDecision::Continue;
auto const& z_index = paint_box.computed_values().z_index();
if (z_index.has_value() && z_index.value() != 0)
return TraversalDecision::Continue;
if (auto* child = paint_box.stacking_context()) {
paint_child(child);
if (!z_index.has_value() || z_index.value() == 0)
paint_child(child);
return TraversalDecision::SkipChildrenAndContinue;
}
if (z_index.has_value() && z_index.value() != 0)
return TraversalDecision::Continue;
if (!paint_box.layout_box().is_positioned())
return TraversalDecision::Continue;
// At this point, `paint_box` is a positioned descendant with z-index: auto
// but no stacking context of its own.
// FIXME: This is basically duplicating logic found elsewhere in this same function. Find a way to make this more elegant.