From 8c13b83a84e6412e9e698485228827b03ce96581 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Tue, 11 Jul 2023 15:11:32 -0400 Subject: [PATCH] LibGfx/PNGWriter: Use a better limit for scanline capactiy One scanline is width pixels long, not height pixels. No measurable performance difference, but it annoys me every time I look at this file. --- Userland/Libraries/LibGfx/ImageFormats/PNGWriter.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Userland/Libraries/LibGfx/ImageFormats/PNGWriter.cpp b/Userland/Libraries/LibGfx/ImageFormats/PNGWriter.cpp index 1b2532d3dc..cc093e58b1 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/PNGWriter.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/PNGWriter.cpp @@ -204,19 +204,19 @@ ErrorOr PNGWriter::add_IDAT_chunk(Gfx::Bitmap const& bitmap) }; Filter none_filter { .type = PNG::FilterType::None }; - TRY(none_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.height())); + TRY(none_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.width())); Filter sub_filter { .type = PNG::FilterType::Sub }; - TRY(sub_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.height())); + TRY(sub_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.width())); Filter up_filter { .type = PNG::FilterType::Up }; - TRY(up_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.height())); + TRY(up_filter.buffer.try_ensure_capacity(sizeof(Pixel) * bitmap.width())); Filter average_filter { .type = PNG::FilterType::Average }; - TRY(average_filter.buffer.try_ensure_capacity(sizeof(ARGB32) * bitmap.height())); + TRY(average_filter.buffer.try_ensure_capacity(sizeof(ARGB32) * bitmap.width())); Filter paeth_filter { .type = PNG::FilterType::Paeth }; - TRY(paeth_filter.buffer.try_ensure_capacity(sizeof(ARGB32) * bitmap.height())); + TRY(paeth_filter.buffer.try_ensure_capacity(sizeof(ARGB32) * bitmap.width())); auto pixel_x_minus_1 = Pixel::gfx_to_png(dummy_scanline[0]); auto pixel_xy_minus_1 = Pixel::gfx_to_png(dummy_scanline[0]);