From 8c1a6a8436600e4b0467ac66705e0abc7407f5bd Mon Sep 17 00:00:00 2001 From: sin-ack Date: Tue, 10 Aug 2021 00:02:04 +0000 Subject: [PATCH] LibGUI: Default TreeView to SelectionBehavior::SelectItems AbstractTableView (which TreeView inherits from) sets the selection behavior of the view to SelectRows. This is not how TreeViews are used in most of the system, and TreeView::paint_event actually always draws with the assumption of selecting individual items. This commit defines the expected selection behavior for TreeViews. Users of TreeView can still override this via TreeView::set_selection_behavior. --- Userland/Libraries/LibGUI/TreeView.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Userland/Libraries/LibGUI/TreeView.cpp b/Userland/Libraries/LibGUI/TreeView.cpp index 1ec3202e92..50e1de35d9 100644 --- a/Userland/Libraries/LibGUI/TreeView.cpp +++ b/Userland/Libraries/LibGUI/TreeView.cpp @@ -34,6 +34,7 @@ TreeView::MetadataForIndex& TreeView::ensure_metadata_for_index(const ModelIndex TreeView::TreeView() { + set_selection_behavior(SelectionBehavior::SelectItems); set_fill_with_background_color(true); set_background_role(ColorRole::Base); set_foreground_role(ColorRole::BaseText);