From 8c73d85a65ff576d87ff102d614442745a54c704 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sat, 13 Nov 2021 13:29:07 +0000 Subject: [PATCH] LibJS: Fix logic typo in round_duration() remainder calculation For unit == "hour", the remainder would not return the difference between fractional_hours and hours, but fractional_hours and days. --- Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp index 996d9f325a..0643c45dd1 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp @@ -1048,7 +1048,7 @@ ThrowCompletionOr round_duration(GlobalObject& global_object, d hours = (double)round_number_to_increment(fractional_hours, increment, rounding_mode); // c. Set remainder to fractionalHours - hours. - remainder = fractional_hours - days; + remainder = fractional_hours - hours; // d. Set minutes, seconds, milliseconds, microseconds, and nanoseconds to 0. minutes = 0;