RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibWeb: Fix typo (original_relative_time -> origin_relative_time)

Browse source
This commit is contained in:
Matthew Olsson 2024-02-03 18:22:44 -07:00 • committed by Andreas Kling
parent a27dd03dcc
commit 8c80d0ee02
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Animations/Animation.cpp
View file

@ -344,12 +344,12 @@ Optional<double> Animation::convert_a_timeline_time_to_an_origin_relative_time(O
// 5. If there is no procedure to convert a timeline time to an origin-relative time for the timeline associated // 5. If there is no procedure to convert a timeline time to an origin-relative time for the timeline associated
// with animation, return an unresolved time value. // with animation, return an unresolved time value.
if (!m_timeline->can_convert_a_timeline_time_to_an_original_relative_time()) if (!m_timeline->can_convert_a_timeline_time_to_an_origin_relative_time())
return {}; return {};
// 6. Return the result of converting timeline time to an origin-relative time using the procedure defined for the // 6. Return the result of converting timeline time to an origin-relative time using the procedure defined for the
// timeline associated with animation. // timeline associated with animation.
return m_timeline->convert_a_timeline_time_to_an_original_relative_time(timeline_time); return m_timeline->convert_a_timeline_time_to_an_origin_relative_time(timeline_time);
} }
// https://www.w3.org/TR/web-animations-1/#animation-document-for-timing // https://www.w3.org/TR/web-animations-1/#animation-document-for-timing

4
Userland/Libraries/LibWeb/Animations/AnimationTimeline.h
View file

@ -26,8 +26,8 @@ public:
bool is_monotonically_increasing() const { return m_is_monotonically_increasing; } bool is_monotonically_increasing() const { return m_is_monotonically_increasing; }
// https://www.w3.org/TR/web-animations-1/#timeline-time-to-origin-relative-time // https://www.w3.org/TR/web-animations-1/#timeline-time-to-origin-relative-time
virtual Optional<double> convert_a_timeline_time_to_an_original_relative_time(Optional<double>) { VERIFY_NOT_REACHED(); } virtual Optional<double> convert_a_timeline_time_to_an_origin_relative_time(Optional<double>) { VERIFY_NOT_REACHED(); }
virtual bool can_convert_a_timeline_time_to_an_original_relative_time() const { return false; } virtual bool can_convert_a_timeline_time_to_an_origin_relative_time() const { return false; }
void associate_with_animation(JS::NonnullGCPtr<Animation> value) { m_associated_animations.set(value); } void associate_with_animation(JS::NonnullGCPtr<Animation> value) { m_associated_animations.set(value); }
void disassociate_with_animation(JS::NonnullGCPtr<Animation> value) { m_associated_animations.remove(value); } void disassociate_with_animation(JS::NonnullGCPtr<Animation> value) { m_associated_animations.remove(value); }

2
Userland/Libraries/LibWeb/Animations/DocumentTimeline.cpp
View file

@ -30,7 +30,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<DocumentTimeline>> DocumentTimeline::constr
} }
// https://www.w3.org/TR/web-animations-1/#ref-for-timeline-time-to-origin-relative-time // https://www.w3.org/TR/web-animations-1/#ref-for-timeline-time-to-origin-relative-time
Optional<double> DocumentTimeline::convert_a_timeline_time_to_an_original_relative_time(Optional<double> timeline_time) Optional<double> DocumentTimeline::convert_a_timeline_time_to_an_origin_relative_time(Optional<double> timeline_time)
{ {
// To convert a timeline time, timeline time, to an origin-relative time for a document timeline, timeline, return // To convert a timeline time, timeline time, to an origin-relative time for a document timeline, timeline, return
// the sum of the timeline time and timeline’s origin time. If timeline is inactive, return an unresolved time // the sum of the timeline time and timeline’s origin time. If timeline is inactive, return an unresolved time

4
Userland/Libraries/LibWeb/Animations/DocumentTimeline.h
View file

@ -29,8 +29,8 @@ public:
virtual WebIDL::ExceptionOr<void> set_current_time(Optional<double> current_time) override; virtual WebIDL::ExceptionOr<void> set_current_time(Optional<double> current_time) override;
virtual bool is_inactive() const override; virtual bool is_inactive() const override;
virtual Optional<double> convert_a_timeline_time_to_an_original_relative_time(Optional<double>) override; virtual Optional<double> convert_a_timeline_time_to_an_origin_relative_time(Optional<double>) override;
virtual bool can_convert_a_timeline_time_to_an_original_relative_time() const override { return true; } virtual bool can_convert_a_timeline_time_to_an_origin_relative_time() const override { return true; }
private: private:
DocumentTimeline(JS::Realm&, DOM::Document&, HighResolutionTime::DOMHighResTimeStamp origin_time); DocumentTimeline(JS::Realm&, DOM::Document&, HighResolutionTime::DOMHighResTimeStamp origin_time);