mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 13:38:11 +00:00
LibWeb: Move event listeners, handlers and callbacks to the GC heap
This patch moves the following things to being GC-allocated: - Bindings::CallbackType - HTML::EventHandler - DOM::IDLEventListener - DOM::DOMEventListener - DOM::NodeFilter Note that we only use PlatformObject for things that might be exposed to web content. Anything that is only used internally inherits directly from JS::Cell instead, making them a bit more lightweight.
This commit is contained in:
parent
967a3e5a45
commit
8cda70c892
57 changed files with 425 additions and 345 deletions
|
@ -26,7 +26,7 @@ NodeIterator::~NodeIterator()
|
|||
}
|
||||
|
||||
// https://dom.spec.whatwg.org/#dom-document-createnodeiterator
|
||||
NonnullRefPtr<NodeIterator> NodeIterator::create(Node& root, unsigned what_to_show, RefPtr<NodeFilter> filter)
|
||||
NonnullRefPtr<NodeIterator> NodeIterator::create(Node& root, unsigned what_to_show, NodeFilter* filter)
|
||||
{
|
||||
// 1. Let iterator be a new NodeIterator object.
|
||||
// 2. Set iterator’s root and iterator’s reference to root.
|
||||
|
@ -37,7 +37,7 @@ NonnullRefPtr<NodeIterator> NodeIterator::create(Node& root, unsigned what_to_sh
|
|||
iterator->m_what_to_show = what_to_show;
|
||||
|
||||
// 5. Set iterator’s filter to filter.
|
||||
iterator->m_filter = move(filter);
|
||||
iterator->m_filter = JS::make_handle(filter);
|
||||
|
||||
// 6. Return iterator.
|
||||
return iterator;
|
||||
|
@ -133,7 +133,7 @@ JS::ThrowCompletionOr<NodeFilter::Result> NodeIterator::filter(Node& node)
|
|||
return NodeFilter::FILTER_SKIP;
|
||||
|
||||
// 4. If traverser’s filter is null, then return FILTER_ACCEPT.
|
||||
if (!m_filter)
|
||||
if (!m_filter.cell())
|
||||
return NodeFilter::FILTER_ACCEPT;
|
||||
|
||||
// 5. Set traverser’s active flag.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue