RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:38:11 +00:00
Code Issues Activity Actions

LibWeb: Move event listeners, handlers and callbacks to the GC heap

Browse source 
This patch moves the following things to being GC-allocated:
- Bindings::CallbackType
- HTML::EventHandler
- DOM::IDLEventListener
- DOM::DOMEventListener
- DOM::NodeFilter

Note that we only use PlatformObject for things that might be exposed
to web content. Anything that is only used internally inherits directly
from JS::Cell instead, making them a bit more lightweight.
This commit is contained in:
Andreas Kling 2022-08-08 14:12:01 +02:00
parent 967a3e5a45
commit 8cda70c892
57 changed files with 425 additions and 345 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -577,9 +577,9 @@ Bindings::CallbackType* XMLHttpRequest::onreadystatechange()
return event_handler_attribute(Web::XHR::EventNames::readystatechange);
}
void XMLHttpRequest::set_onreadystatechange(Optional<Bindings::CallbackType> value)
void XMLHttpRequest::set_onreadystatechange(Bindings::CallbackType* value)
{
set_event_handler_attribute(Web::XHR::EventNames::readystatechange, move(value));
set_event_handler_attribute(Web::XHR::EventNames::readystatechange, value);
}
// https://xhr.spec.whatwg.org/#the-getallresponseheaders()-method