RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:57:44 +00:00
Code Issues Activity Actions

LibWeb: Fix normalizing namespace in NamedNodeMap::get_attribute_ns

Browse source 
There was a typo which effectively meant that the namespace was always
being set to null when given.
This commit is contained in:
Shannon Booth 2024-01-13 17:30:32 +13:00 • committed by Andreas Kling
parent 636a85f04e
commit 8cf783b260
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp
View file

@ -188,7 +188,7 @@ Attr const* NamedNodeMap::get_attribute_ns(Optional<FlyString> const& namespace_
// 1. If namespace is the empty string, then set it to null. // 1. If namespace is the empty string, then set it to null.
Optional<FlyString> normalized_namespace; Optional<FlyString> normalized_namespace;
if (namespace_.has_value() && namespace_->is_empty()) if (namespace_ != String {})
normalized_namespace = namespace_; normalized_namespace = namespace_;
// 2. Return the attribute in element’s attribute list whose namespace is namespace and local name is localName, if any; otherwise null. // 2. Return the attribute in element’s attribute list whose namespace is namespace and local name is localName, if any; otherwise null.