RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:47:44 +00:00
Code Issues Activity Actions

WindowServer: Change rendering drag&drop to use the Overlay class

Browse source 
This enables flicker-free rendering.
This commit is contained in:
Tom 2021-06-25 12:08:23 -06:00 • committed by Andreas Kling
parent 84cab29c59
commit 8cfb4c82f0
7 changed files with 99 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Userland/Services/WindowServer/Overlays.h
View file

@ -26,6 +26,7 @@ public:
enum class ZOrder {
WindowGeometry,
Dnd,
ScreenNumber,
};
[[nodiscard]] virtual ZOrder zorder() const = 0;
@ -39,7 +40,7 @@ public:
virtual void theme_changed()
{
rect_changed();
rect_changed(m_rect);
}
bool invalidate();
@ -49,7 +50,7 @@ protected:
void set_rect(Gfx::IntRect const&);
virtual void rect_changed() {};
virtual void rect_changed(Gfx::IntRect const&) {};
private:
void clear_invalidated() { m_invalidated = false; }
@ -76,7 +77,7 @@ protected:
BitmapOverlay();
void clear_bitmaps();
virtual void rect_changed() override;
virtual void rect_changed(Gfx::IntRect const&) override;
private:
RefPtr<MultiScaleBitmaps> m_bitmaps;
@ -97,10 +98,16 @@ protected:
void set_content_rect(Gfx::IntRect const&);
void clear_bitmaps();
virtual void rect_changed() override;
virtual void rect_changed(Gfx::IntRect const&) override;
void rerender_on_location_change(bool value)
{
m_rerender_on_location_change = value;
}
private:
RefPtr<MultiScaleBitmaps> m_rendered_bitmaps;
bool m_rerender_on_location_change { false };
};
class ScreenNumberOverlay : public RectangularOverlay {
@ -143,4 +150,25 @@ private:
Gfx::IntRect m_label_rect;
};
class DndOverlay : public BitmapOverlay {
public:
DndOverlay(String const&, Gfx::Bitmap const*);
void cursor_moved()
{
update_rect();
}
virtual ZOrder zorder() const override { return ZOrder::Dnd; }
virtual RefPtr<Gfx::Bitmap> create_bitmap(int) override;
private:
Gfx::Font const& font();
void update_rect();
RefPtr<Gfx::Bitmap> m_bitmap;
String m_text;
Gfx::IntRect m_label_rect;
};
}