From 8d1e6e9175a7cc511fd836c9e85f6eadcc6dd650 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 13 Jun 2021 00:58:25 +0100 Subject: [PATCH] LibJS: Don't repeat attributes in {Date,Symbol}Constructor --- Userland/Libraries/LibJS/Runtime/DateConstructor.cpp | 7 ++++--- Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp | 5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/DateConstructor.cpp b/Userland/Libraries/LibJS/Runtime/DateConstructor.cpp index 08f0f511ba..ac2865df9b 100644 --- a/Userland/Libraries/LibJS/Runtime/DateConstructor.cpp +++ b/Userland/Libraries/LibJS/Runtime/DateConstructor.cpp @@ -134,9 +134,10 @@ void DateConstructor::initialize(GlobalObject& global_object) define_property(vm.names.length, Value(7), Attribute::Configurable); - define_native_function(vm.names.now, now, 0, Attribute::Writable | Attribute::Configurable); - define_native_function(vm.names.parse, parse, 1, Attribute::Writable | Attribute::Configurable); - define_native_function(vm.names.UTC, utc, 1, Attribute::Writable | Attribute::Configurable); + u8 attr = Attribute::Writable | Attribute::Configurable; + define_native_function(vm.names.now, now, 0, attr); + define_native_function(vm.names.parse, parse, 1, attr); + define_native_function(vm.names.UTC, utc, 1, attr); } DateConstructor::~DateConstructor() diff --git a/Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp b/Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp index cb2a98e7e5..4e0a029624 100644 --- a/Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp +++ b/Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp @@ -25,8 +25,9 @@ void SymbolConstructor::initialize(GlobalObject& global_object) define_property(vm.names.length, Value(0), Attribute::Configurable); - define_native_function(vm.names.for_, for_, 1, Attribute::Writable | Attribute::Configurable); - define_native_function(vm.names.keyFor, key_for, 1, Attribute::Writable | Attribute::Configurable); + u8 attr = Attribute::Writable | Attribute::Configurable; + define_native_function(vm.names.for_, for_, 1, attr); + define_native_function(vm.names.keyFor, key_for, 1, attr); #define __JS_ENUMERATE(SymbolName, snake_name) \ define_property(vm.names.SymbolName, vm.well_known_symbol_##snake_name(), 0);