RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:37:44 +00:00
Code Issues Activity Actions

LibWeb: Make ImageBox ask ImageProvider for intrinsic size and ratio

Browse source 
This paves the way for ImageProvider to have something vector-based
underneath. :^)
This commit is contained in:
Andreas Kling 2023-05-20 16:27:31 +02:00
parent 4ee1e5b224
commit 8d3240d633
9 changed files with 71 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Layout/ImageBox.cpp
View file

@ -23,18 +23,9 @@ ImageBox::~ImageBox() = default;
void ImageBox::prepare_for_replaced_layout()
{
auto bitmap = m_image_provider.current_image_bitmap();
if (!bitmap) {
set_intrinsic_width(0);
set_intrinsic_height(0);
} else {
auto width = bitmap->width();
auto height = bitmap->height();
set_intrinsic_width(width);
set_intrinsic_height(height);
set_intrinsic_aspect_ratio(static_cast<float>(width) / static_cast<float>(height));
}
set_intrinsic_width(m_image_provider.intrinsic_width());
set_intrinsic_height(m_image_provider.intrinsic_height());
set_intrinsic_aspect_ratio(m_image_provider.intrinsic_aspect_ratio());
if (renders_as_alt_text()) {
auto& image_element = verify_cast<HTML::HTMLImageElement>(dom_node());

6
Userland/Libraries/LibWeb/Layout/ImageProvider.h
View file

@ -6,12 +6,18 @@
#pragma once
#include <LibWeb/PixelUnits.h>
namespace Web::Layout {
class ImageProvider {
public:
virtual ~ImageProvider() { }
virtual Optional<CSSPixels> intrinsic_width() const = 0;
virtual Optional<CSSPixels> intrinsic_height() const = 0;
virtual Optional<float> intrinsic_aspect_ratio() const = 0;
virtual RefPtr<Gfx::Bitmap const> current_image_bitmap() const = 0;
virtual void set_visible_in_viewport(bool) = 0;
};