From 8d73355c383b8e0be0d68a9d3e2724972d7077bb Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 11 Aug 2020 12:22:19 +0200 Subject: [PATCH] LibELF: Set ELF::Loader::m_symbol_count in constructor Setting it in load() excludes users of ELF::Loader that don't actually call load() but only use the Loader for symbolication purposes. Perhaps the factoring here is not ideal. --- Libraries/LibELF/Loader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibELF/Loader.cpp b/Libraries/LibELF/Loader.cpp index e98594510c..e6b9b3af7a 100644 --- a/Libraries/LibELF/Loader.cpp +++ b/Libraries/LibELF/Loader.cpp @@ -43,6 +43,8 @@ namespace ELF { Loader::Loader(const u8* buffer, size_t size, bool verbose_logging) : m_image(buffer, size, verbose_logging) { + if (m_image.is_valid()) + m_symbol_count = m_image.symbol_count(); } Loader::~Loader() @@ -57,8 +59,6 @@ bool Loader::load() if (!m_image.is_valid()) return false; - m_symbol_count = m_image.symbol_count(); - if (!layout()) return false;