From 8d7a5afe58b9c6ad27a0a3f0ef5035dcd9d657f9 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 24 Feb 2024 16:27:17 -0500 Subject: [PATCH] LibWeb: Increase the transient activation duration from 5ms to 5s It seems we were errantly mixing seconds and milliseconds in this transient activation timeout. Increase it to 5 seconds, and be explicit about its type - DOMHighResTimeStamp is by definition milliseconds. --- Userland/Libraries/LibWeb/HTML/Window.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/Window.cpp b/Userland/Libraries/LibWeb/HTML/Window.cpp index 8dfc702be2..c8b8b2e008 100644 --- a/Userland/Libraries/LibWeb/HTML/Window.cpp +++ b/Userland/Libraries/LibWeb/HTML/Window.cpp @@ -604,7 +604,7 @@ bool Window::has_transient_activation() const { // The transient activation duration is expected be at most a few seconds, so that the user can possibly // perceive the link between an interaction with the page and the page calling the activation-gated API. - auto transient_activation_duration = 5; + static constexpr HighResolutionTime::DOMHighResTimeStamp transient_activation_duration_ms = 5000; // AD-HOC: Due to resource limitations on CI, we cannot rely on the time between the activation timestamp and the // transient activation timeout being predictable. So we allow tests to indicate when they want the next @@ -621,7 +621,7 @@ bool Window::has_transient_activation() const // is greater than or equal to the last activation timestamp in W if (current_time >= m_last_activation_timestamp) { // and less than the last activation timestamp in W plus the transient activation duration - if (current_time < m_last_activation_timestamp + transient_activation_duration) { + if (current_time < m_last_activation_timestamp + transient_activation_duration_ms) { // then W is said to have transient activation. return true; }