RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:47:45 +00:00
Code Issues Activity Actions

Kernel: Validate changed framebuffer resolution

Browse source 
Now we check before we set a FBResolution if the BXVGA device is capable
of setting the requested resolution.
If not, we revert the resolution to the previous one and return an error
to userspace.

Fixes #451.
This commit is contained in:
Liav A 2020-02-26 18:56:58 +02:00 • committed by Andreas Kling
parent f14c5b29b4
commit 8dbd1cb9fb
2 changed files with 76 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Devices/BXVGADevice.h
View file

@ -52,10 +52,17 @@ private:
virtual bool read_blocks(unsigned, u16, u8*) override { return false; }
virtual bool write_blocks(unsigned, u16, const u8*) override { return false; }
void set_safe_resolution();
void set_register(u16 index, u16 value);
u16 get_register(u16 index);
bool validate_setup_resolution(int width, int height);
u32 find_framebuffer_address();
void revert_resolution();
bool test_resolution(int width, int height);
size_t framebuffer_size_in_bytes() const { return m_framebuffer_pitch * m_framebuffer_height * 2; }
void set_resolution(int width, int height);
bool set_resolution(int width, int height);
void set_resolution_registers(int width, int height);
void set_y_offset(int);
PhysicalAddress m_framebuffer_address;