mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 19:27:35 +00:00
LibWeb: Remove unecessary dependence on Window from DOM and WebIDL
These classes only needed Window to get at its realm. Pass a realm directly to construct DOM and WebIDL classes. This change importantly removes the guarantee that a Document will always have a non-null Window object. Only Documents created by a BrowsingContext will have a non-null Window object. Documents created by for example, DocumentFragment, will not have a Window (soon). This incremental commit leaves some workarounds in place to keep other parts of the code building.
This commit is contained in:
parent
8407bf60c5
commit
8de7e49a56
56 changed files with 364 additions and 326 deletions
|
@ -10,7 +10,6 @@
|
|||
#include <AK/Weakable.h>
|
||||
#include <LibWeb/DOM/EventTarget.h>
|
||||
#include <LibWeb/Forward.h>
|
||||
#include <LibWeb/HTML/Window.h>
|
||||
|
||||
namespace Web::DOM {
|
||||
|
||||
|
@ -19,7 +18,7 @@ class AbortSignal final : public EventTarget {
|
|||
WEB_PLATFORM_OBJECT(AbortSignal, EventTarget);
|
||||
|
||||
public:
|
||||
static JS::NonnullGCPtr<AbortSignal> create_with_global_object(HTML::Window&);
|
||||
static JS::NonnullGCPtr<AbortSignal> construct_impl(JS::Realm&);
|
||||
|
||||
virtual ~AbortSignal() override = default;
|
||||
|
||||
|
@ -40,6 +39,7 @@ public:
|
|||
JS::ThrowCompletionOr<void> throw_if_aborted() const;
|
||||
|
||||
private:
|
||||
explicit AbortSignal(JS::Realm&);
|
||||
explicit AbortSignal(HTML::Window&);
|
||||
|
||||
virtual void visit_edges(JS::Cell::Visitor&) override;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue