mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 01:47:34 +00:00
LibWeb: Remove unecessary dependence on Window from DOM and WebIDL
These classes only needed Window to get at its realm. Pass a realm directly to construct DOM and WebIDL classes. This change importantly removes the guarantee that a Document will always have a non-null Window object. Only Documents created by a BrowsingContext will have a non-null Window object. Documents created by for example, DocumentFragment, will not have a Window (soon). This incremental commit leaves some workarounds in place to keep other parts of the code building.
This commit is contained in:
parent
8407bf60c5
commit
8de7e49a56
56 changed files with 364 additions and 326 deletions
|
@ -22,7 +22,7 @@ WebIDL::ExceptionOr<JS::GCPtr<Element>> ParentNode::query_selector(StringView se
|
|||
{
|
||||
auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text);
|
||||
if (!maybe_selectors.has_value())
|
||||
return WebIDL::SyntaxError::create(global_object(), "Failed to parse selector");
|
||||
return WebIDL::SyntaxError::create(realm(), "Failed to parse selector");
|
||||
|
||||
auto selectors = maybe_selectors.value();
|
||||
|
||||
|
@ -45,7 +45,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> ParentNode::query_selector_all(S
|
|||
{
|
||||
auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text);
|
||||
if (!maybe_selectors.has_value())
|
||||
return WebIDL::SyntaxError::create(global_object(), "Failed to parse selector");
|
||||
return WebIDL::SyntaxError::create(realm(), "Failed to parse selector");
|
||||
|
||||
auto selectors = maybe_selectors.value();
|
||||
|
||||
|
@ -60,7 +60,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> ParentNode::query_selector_all(S
|
|||
return IterationDecision::Continue;
|
||||
});
|
||||
|
||||
return StaticNodeList::create(window(), move(elements));
|
||||
return StaticNodeList::create(realm(), move(elements));
|
||||
}
|
||||
|
||||
JS::GCPtr<Element> ParentNode::first_element_child()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue