RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:17:45 +00:00
Code Issues Activity Actions

LibJS: Add spec comments and check for edge cases in Math.sinh

Browse source
This commit is contained in:
davidot 2022-11-28 12:08:01 +01:00 • committed by Andreas Kling
parent 4306462a95
commit 8de8742b7c
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Runtime/MathObject.cpp
View file

@ -600,9 +600,14 @@ JS_DEFINE_NATIVE_FUNCTION(MathObject::log10)
// 21.3.2.31 Math.sinh ( x ), https://tc39.es/ecma262/#sec-math.sinh
JS_DEFINE_NATIVE_FUNCTION(MathObject::sinh)
{
// 1. Let n be ? ToNumber(x).
auto number = TRY(vm.argument(0).to_number(vm));
if (number.is_nan())
return js_nan();
// 2. If n is not finite or n is either +0𝔽 or -0𝔽, return n.
if (!number.is_finite_number() || number.is_positive_zero() || number.is_negative_zero())
return number;
// 3. Return an implementation-approximated Number value representing the result of the hyperbolic sine of ℝ(n).
return Value(::sinh(number.as_double()));
}

4
Userland/Libraries/LibJS/Tests/builtins/Math/Math.sinh.js
View file

@ -3,4 +3,8 @@ test("basic functionality", () => {
expect(Math.sinh(0)).toBe(0);
expect(Math.sinh(1)).toBeCloseTo(1.1752011936438014);
expect(Math.sinh(NaN)).toBe(NaN);
expect(Math.sinh(Number.POSITIVE_INFINITY)).toBe(Number.POSITIVE_INFINITY);
expect(Math.sinh(Number.NEGATIVE_INFINITY)).toBe(Number.NEGATIVE_INFINITY);
expect(Math.sinh(-0.0)).toBe(-0.0);
});