mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 23:37:36 +00:00
LibWeb: Resolve cyclic declaration/definitions involving Length
This remained undetected for a long time as HeaderCheck is disabled by default. This commit makes the following file compile again: // file: compile_me.cpp #include <LibWeb/CSS/GridTrackSize.h> // That's it, this was enough to cause a compilation error.
This commit is contained in:
parent
53eb35caba
commit
8deced39a8
15 changed files with 192 additions and 125 deletions
|
@ -25,6 +25,7 @@ public:
|
|||
GridTrackSize(Length);
|
||||
GridTrackSize(Percentage);
|
||||
GridTrackSize(float);
|
||||
~GridTrackSize();
|
||||
|
||||
static GridTrackSize make_auto();
|
||||
|
||||
|
@ -34,7 +35,7 @@ public:
|
|||
bool is_percentage() const { return m_type == Type::Percentage; }
|
||||
bool is_flexible_length() const { return m_type == Type::FlexibleLength; }
|
||||
|
||||
Length length() const { return m_length; }
|
||||
Length length() const;
|
||||
Percentage percentage() const { return m_percentage; }
|
||||
float flexible_length() const { return m_flexible_length; }
|
||||
|
||||
|
@ -57,7 +58,9 @@ public:
|
|||
|
||||
private:
|
||||
Type m_type;
|
||||
Length m_length { Length::make_px(0) };
|
||||
// Length includes a RefPtr<CalculatedStyleValue> member, but we can't include the header StyleValue.h as it includes
|
||||
// this file already. To break the cyclic dependency, we must initialize m_length in the constructor.
|
||||
Length m_length;
|
||||
Percentage m_percentage { Percentage(0) };
|
||||
float m_flexible_length { 0 };
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue