RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:27:35 +00:00
Code Issues Activity Actions

LibJS: Make Number() constructor spec compliant

Browse source 
By using to_numeric() and adding BigInt handling, we get support for
`Number(123n)`.

Fixes #8125.
This commit is contained in:
Linus Groh 2021-06-19 01:34:17 +01:00
parent 7f8245439b
commit 8e26c7a1dd
2 changed files with 55 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

41
Userland/Libraries/LibJS/Tests/builtins/Number/Number.js
View file

@ -1,33 +1,46 @@
test("basic functionality", () => {
test("length is 1", () => {
expect(Number).toHaveLength(1);
expect(Number.name).toBe("Number");
expect(Number.prototype).not.toHaveProperty("length");
});
test("constructor without new", () => {
expect(typeof Number()).toBe("number");
expect(typeof new Number()).toBe("object");
expect(Number()).toBe(0);
expect(new Number().valueOf()).toBe(0);
expect(Number(123)).toBe(123);
expect(Number(-123)).toBe(-123);
expect(Number(123n)).toBe(123);
expect(Number(-123n)).toBe(-123);
expect(Number("42")).toBe(42);
expect(new Number("42").valueOf()).toBe(42);
expect(Number(null)).toBe(0);
expect(new Number(null).valueOf()).toBe(0);
expect(Number(true)).toBe(1);
expect(new Number(true).valueOf()).toBe(1);
expect(Number("Infinity")).toBe(Infinity);
expect(new Number("Infinity").valueOf()).toBe(Infinity);
expect(Number("+Infinity")).toBe(Infinity);
expect(new Number("+Infinity").valueOf()).toBe(Infinity);
expect(Number("-Infinity")).toBe(-Infinity);
expect(new Number("-Infinity").valueOf()).toBe(-Infinity);
expect(Number(undefined)).toBeNaN();
expect(new Number(undefined).valueOf()).toBeNaN();
expect(Number({})).toBeNaN();
expect(new Number({}).valueOf()).toBeNaN();
expect(Number({ a: 1 })).toBeNaN();
expect(new Number({ a: 1 }).valueOf()).toBeNaN();
expect(Number([1, 2, 3])).toBeNaN();
expect(new Number([1, 2, 3]).valueOf()).toBeNaN();
expect(Number("foo")).toBeNaN();
});
test("constructor with new", () => {
expect(typeof new Number()).toBe("object");
expect(new Number().valueOf()).toBe(0);
expect(new Number(123).valueOf()).toBe(123);
expect(new Number(-123).valueOf()).toBe(-123);
expect(new Number(123n).valueOf()).toBe(123);
expect(new Number(-123n).valueOf()).toBe(-123);
expect(new Number("42").valueOf()).toBe(42);
expect(new Number(null).valueOf()).toBe(0);
expect(new Number(true).valueOf()).toBe(1);
expect(new Number("Infinity").valueOf()).toBe(Infinity);
expect(new Number("+Infinity").valueOf()).toBe(Infinity);
expect(new Number("-Infinity").valueOf()).toBe(-Infinity);
expect(new Number(undefined).valueOf()).toBeNaN();
expect(new Number({}).valueOf()).toBeNaN();
expect(new Number({ a: 1 }).valueOf()).toBeNaN();
expect(new Number([1, 2, 3]).valueOf()).toBeNaN();
expect(new Number("foo").valueOf()).toBeNaN();
});