From 8e4a4fd4db56d9e6fd1d16638872d9703b3bb26d Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Fri, 10 Sep 2021 20:42:50 +0100 Subject: [PATCH] LibWeb: Remove "takes integer value" concept from parse_css_value() This was only needed when numeric values had to be wrapped as Lengths, and now serves no purpose. --- Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp index f22b0a1cab..dc6166e919 100644 --- a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp +++ b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp @@ -2872,22 +2872,8 @@ RefPtr Parser::parse_css_value(PropertyID property_id, TokenStream Parser::parse_css_value(ParsingContext const& context, PropertyID property_id, StyleComponentValueRule const& component_value) +RefPtr Parser::parse_css_value(ParsingContext const& context, PropertyID, StyleComponentValueRule const& component_value) { - // FIXME: Figure out if we still need takes_integer_value, and if so, move this information - // into Properties.json. - auto takes_integer_value = [](PropertyID property_id) -> bool { - return property_id == PropertyID::ZIndex - || property_id == PropertyID::FontWeight - || property_id == PropertyID::Custom; - }; - if (takes_integer_value(property_id) && component_value.is(Token::Type::Number)) { - auto number = component_value.token(); - if (number.m_number_type == Token::NumberType::Integer) { - return LengthStyleValue::create(Length::make_px(number.to_integer())); - } - } - if (auto builtin = parse_builtin_value(context, component_value)) return builtin;