RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:57:35 +00:00
Code Issues Activity Actions

LibWeb: Remove the NoInstanceWrapper extended IDL attribute

Browse source 
No interfaces require wrappers anymore, so we can just make this the
default mode.
This commit is contained in:
Andreas Kling 2022-09-05 11:41:26 +02:00
parent 1bd4ad8b6d
commit 8f110e0fb1
31 changed files with 32 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLParser.cpp
View file

@ -570,11 +570,8 @@ void Parser::parse_interface(Interface& interface)
parse_function(extended_attributes, interface); parse_function(extended_attributes, interface);
} }
if (interface.extended_attributes.contains("NoInstanceWrapper")) { interface.wrapper_class = interface.name;
interface.wrapper_class = interface.name;
} else {
interface.wrapper_class = String::formatted("{}Wrapper", interface.name);
}
interface.wrapper_base_class = String::formatted("{}Wrapper", interface.parent_name.is_empty() ? String::empty() : interface.parent_name); interface.wrapper_base_class = String::formatted("{}Wrapper", interface.parent_name.is_empty() ? String::empty() : interface.parent_name);
interface.constructor_class = String::formatted("{}Constructor", interface.name); interface.constructor_class = String::formatted("{}Constructor", interface.name);
interface.prototype_class = String::formatted("{}Prototype", interface.name); interface.prototype_class = String::formatted("{}Prototype", interface.name);

2
Userland/Libraries/LibWeb/CSS/CSSConditionRule.idl
View file

@ -1,6 +1,6 @@
#import <CSS/CSSGroupingRule.idl> #import <CSS/CSSGroupingRule.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSConditionRule : CSSGroupingRule { interface CSSConditionRule : CSSGroupingRule {
attribute CSSOMString conditionText; attribute CSSOMString conditionText;
}; };

2
Userland/Libraries/LibWeb/CSS/CSSFontFaceRule.idl
View file

@ -1,7 +1,7 @@
#import <CSS/CSSRule.idl> #import <CSS/CSSRule.idl>
#import <CSS/CSSStyleDeclaration.idl> #import <CSS/CSSStyleDeclaration.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSFontFaceRule : CSSRule { interface CSSFontFaceRule : CSSRule {
readonly attribute CSSStyleDeclaration style; readonly attribute CSSStyleDeclaration style;
}; };

2
Userland/Libraries/LibWeb/CSS/CSSGroupingRule.idl
View file

@ -1,7 +1,7 @@
#import <CSS/CSSRule.idl> #import <CSS/CSSRule.idl>
#import <CSS/CSSRuleList.idl> #import <CSS/CSSRuleList.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSGroupingRule : CSSRule { interface CSSGroupingRule : CSSRule {
[SameObject, ImplementedAs=css_rules_for_bindings] readonly attribute CSSRuleList cssRules; [SameObject, ImplementedAs=css_rules_for_bindings] readonly attribute CSSRuleList cssRules;
unsigned long insertRule(CSSOMString rule, optional unsigned long index = 0); unsigned long insertRule(CSSOMString rule, optional unsigned long index = 0);

2
Userland/Libraries/LibWeb/CSS/CSSImportRule.idl
View file

@ -2,7 +2,7 @@
#import <CSS/CSSStyleSheet.idl> #import <CSS/CSSStyleSheet.idl>
#import <CSS/MediaList.idl> #import <CSS/MediaList.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSImportRule : CSSRule { interface CSSImportRule : CSSRule {
readonly attribute USVString href; readonly attribute USVString href;
// [SameObject, PutForwards=mediaText] readonly attribute MediaList media; // [SameObject, PutForwards=mediaText] readonly attribute MediaList media;

2
Userland/Libraries/LibWeb/CSS/CSSMediaRule.idl
View file

@ -1,7 +1,7 @@
#import <CSS/CSSConditionRule.idl> #import <CSS/CSSConditionRule.idl>
#import <CSS/MediaList.idl> #import <CSS/MediaList.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSMediaRule : CSSConditionRule { interface CSSMediaRule : CSSConditionRule {
[SameObject, PutForwards=mediaText] readonly attribute MediaList media; [SameObject, PutForwards=mediaText] readonly attribute MediaList media;
}; };

2
Userland/Libraries/LibWeb/CSS/CSSRule.idl
View file

@ -1,6 +1,6 @@
#import <CSS/CSSStyleSheet.idl> #import <CSS/CSSStyleSheet.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSRule { interface CSSRule {
attribute CSSOMString cssText; attribute CSSOMString cssText;

2
Userland/Libraries/LibWeb/CSS/CSSRuleList.idl
View file

@ -1,6 +1,6 @@
#import <CSS/CSSRule.idl> #import <CSS/CSSRule.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSRuleList { interface CSSRuleList {
getter CSSRule? item(unsigned long index); getter CSSRule? item(unsigned long index);

2
Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.idl
View file

@ -1,4 +1,4 @@
[NoInstanceWrapper] []
interface CSSStyleDeclaration { interface CSSStyleDeclaration {
readonly attribute unsigned long length; readonly attribute unsigned long length;

2
Userland/Libraries/LibWeb/CSS/CSSStyleRule.idl
View file

@ -1,7 +1,7 @@
#import <CSS/CSSRule.idl> #import <CSS/CSSRule.idl>
#import <CSS/CSSStyleDeclaration.idl> #import <CSS/CSSStyleDeclaration.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSStyleRule : CSSRule { interface CSSStyleRule : CSSRule {
attribute CSSOMString selectorText; attribute CSSOMString selectorText;

2
Userland/Libraries/LibWeb/CSS/CSSSupportsRule.idl
View file

@ -1,5 +1,5 @@
#import <CSS/CSSConditionRule.idl> #import <CSS/CSSConditionRule.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface CSSSupportsRule : CSSConditionRule { interface CSSSupportsRule : CSSConditionRule {
}; };

2
Userland/Libraries/LibWeb/CSS/MediaList.idl
View file

@ -1,4 +1,4 @@
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface MediaList { interface MediaList {
[LegacyNullToEmptyString] stringifier attribute CSSOMString mediaText; [LegacyNullToEmptyString] stringifier attribute CSSOMString mediaText;
readonly attribute unsigned long length; readonly attribute unsigned long length;

2
Userland/Libraries/LibWeb/CSS/MediaQueryListEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[NoInstanceWrapper] []
interface MediaQueryListEvent : Event { interface MediaQueryListEvent : Event {
constructor(CSSOMString type, optional MediaQueryListEventInit eventInitDict = {}); constructor(CSSOMString type, optional MediaQueryListEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/CSS/StyleSheetList.idl
View file

@ -1,6 +1,6 @@
#import <CSS/CSSStyleSheet.idl> #import <CSS/CSSStyleSheet.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface StyleSheetList { interface StyleSheetList {
getter CSSStyleSheet? item(unsigned long index); getter CSSStyleSheet? item(unsigned long index);
readonly attribute unsigned long length; readonly attribute unsigned long length;

2
Userland/Libraries/LibWeb/DOM/AbstractRange.idl
View file

@ -1,4 +1,4 @@
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface AbstractRange { interface AbstractRange {
readonly attribute Node startContainer; readonly attribute Node startContainer;
readonly attribute unsigned long startOffset; readonly attribute unsigned long startOffset;

2
Userland/Libraries/LibWeb/DOM/CustomEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[Exposed=(Window,Worker), NoInstanceWrapper] [Exposed=(Window,Worker)]
interface CustomEvent : Event { interface CustomEvent : Event {
constructor(DOMString type, optional CustomEventInit eventInitDict = {}); constructor(DOMString type, optional CustomEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/DOM/DOMTokenList.idl
View file

@ -1,4 +1,4 @@
[NoInstanceWrapper] []
interface DOMTokenList { interface DOMTokenList {
readonly attribute unsigned long length; readonly attribute unsigned long length;
getter DOMString? item(unsigned long index); getter DOMString? item(unsigned long index);

2
Userland/Libraries/LibWeb/DOM/Event.idl
View file

@ -1,6 +1,6 @@
#import <DOM/EventTarget.idl> #import <DOM/EventTarget.idl>
[NoInstanceWrapper] []
interface Event { interface Event {
constructor(DOMString type, optional EventInit eventInitDict = {}); constructor(DOMString type, optional EventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/DOM/NamedNodeMap.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Attribute.idl> #import <DOM/Attribute.idl>
[Exposed=Window, LegacyUnenumerableNamedProperties, NoInstanceWrapper] [Exposed=Window, LegacyUnenumerableNamedProperties]
interface NamedNodeMap { interface NamedNodeMap {
readonly attribute unsigned long length; readonly attribute unsigned long length;

2
Userland/Libraries/LibWeb/DOM/NodeIterator.idl
View file

@ -1,7 +1,7 @@
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/NodeFilter.idl> #import <DOM/NodeFilter.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface NodeIterator { interface NodeIterator {
[SameObject] readonly attribute Node root; [SameObject] readonly attribute Node root;

2
Userland/Libraries/LibWeb/DOM/Range.idl
View file

@ -1,7 +1,7 @@
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/AbstractRange.idl> #import <DOM/AbstractRange.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface Range : AbstractRange { interface Range : AbstractRange {
constructor(); constructor();

2
Userland/Libraries/LibWeb/DOM/StaticRange.idl
View file

@ -1,7 +1,7 @@
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/AbstractRange.idl> #import <DOM/AbstractRange.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface StaticRange : AbstractRange { interface StaticRange : AbstractRange {
constructor(StaticRangeInit init); constructor(StaticRangeInit init);
}; };

2
Userland/Libraries/LibWeb/DOM/TreeWalker.idl
View file

@ -1,7 +1,7 @@
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/NodeFilter.idl> #import <DOM/NodeFilter.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface TreeWalker { interface TreeWalker {
[SameObject] readonly attribute Node root; [SameObject] readonly attribute Node root;

2
Userland/Libraries/LibWeb/HTML/CloseEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[NoInstanceWrapper] []
interface CloseEvent : Event { interface CloseEvent : Event {
constructor(DOMString type, optional CloseEventInit eventInitDict = {}); constructor(DOMString type, optional CloseEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/HTML/MessageEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[NoInstanceWrapper] []
interface MessageEvent : Event { interface MessageEvent : Event {
constructor(DOMString type, optional MessageEventInit eventInitDict = {}); constructor(DOMString type, optional MessageEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/HTML/PromiseRejectionEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[Exposed=(Window,Worker), NoInstanceWrapper] [Exposed=(Window,Worker)]
interface PromiseRejectionEvent : Event { interface PromiseRejectionEvent : Event {
constructor(DOMString type, PromiseRejectionEventInit eventInitDict); constructor(DOMString type, PromiseRejectionEventInit eventInitDict);

2
Userland/Libraries/LibWeb/HTML/SubmitEvent.idl
View file

@ -1,7 +1,7 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
#import <HTML/HTMLElement.idl> #import <HTML/HTMLElement.idl>
[NoInstanceWrapper] []
interface SubmitEvent : Event { interface SubmitEvent : Event {
constructor(DOMString type, optional SubmitEventInit eventInitDict = {}); constructor(DOMString type, optional SubmitEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/UIEvents/FocusEvent.idl
View file

@ -1,6 +1,6 @@
#import <UIEvents/UIEvent.idl> #import <UIEvents/UIEvent.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface FocusEvent : UIEvent { interface FocusEvent : UIEvent {
constructor(DOMString type, optional FocusEventInit eventInitDict = {}); constructor(DOMString type, optional FocusEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/UIEvents/KeyboardEvent.idl
View file

@ -1,6 +1,6 @@
#import <UIEvents/EventModifier.idl> #import <UIEvents/EventModifier.idl>
[Exposed=Window, NoInstanceWrapper] [Exposed=Window]
interface KeyboardEvent : UIEvent { interface KeyboardEvent : UIEvent {
constructor(DOMString type, optional KeyboardEventInit eventInitDict = {}); constructor(DOMString type, optional KeyboardEventInit eventInitDict = {});

2
Userland/Libraries/LibWeb/UIEvents/UIEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[NoInstanceWrapper] []
interface UIEvent : Event { interface UIEvent : Event {
constructor(DOMString type, optional UIEventInit eventInitDict = {}); constructor(DOMString type, optional UIEventInit eventInitDict = {});
readonly attribute Window? view; readonly attribute Window? view;

2
Userland/Libraries/LibWeb/XHR/ProgressEvent.idl
View file

@ -1,6 +1,6 @@
#import <DOM/Event.idl> #import <DOM/Event.idl>
[NoInstanceWrapper] []
interface ProgressEvent : Event { interface ProgressEvent : Event {
constructor(DOMString type, optional ProgressEventInit eventInitDict = {}); constructor(DOMString type, optional ProgressEventInit eventInitDict = {});