RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:55:08 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Make HTML::Script GC-allocated

Browse source 
This allows the garbage collector to keep HTML::Script objects alive and
fixes a bug where a HTMLScriptElement could get GC'd while its code was
executing.
This commit is contained in:
Andreas Kling 2022-09-05 14:32:33 +02:00
parent 00c8f07192
commit 8f9ed415a0
6 changed files with 35 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/HTML/Scripting/ClassicScript.h
View file

@ -16,6 +16,8 @@ namespace Web::HTML {
class ClassicScript final
: public Script
, public JS::Script::HostDefined {
JS_CELL(ClassicScript, Script);
public:
virtual ~ClassicScript() override;
@ -23,7 +25,7 @@ public:
No,
Yes,
};
static NonnullRefPtr<ClassicScript> create(String filename, StringView source, EnvironmentSettingsObject&, AK::URL base_url, size_t source_line_number = 1, MutedErrors = MutedErrors::No);
static JS::NonnullGCPtr<ClassicScript> create(String filename, StringView source, EnvironmentSettingsObject&, AK::URL base_url, size_t source_line_number = 1, MutedErrors = MutedErrors::No);
JS::Script* script_record() { return m_script_record; }
JS::Script const* script_record() const { return m_script_record; }
@ -39,7 +41,10 @@ public:
private:
ClassicScript(AK::URL base_url, String filename, EnvironmentSettingsObject& environment_settings_object);
RefPtr<JS::Script> m_script_record;
virtual void visit_edges(Cell::Visitor&) override;
virtual void visit_host_defined_self(Cell::Visitor&) override;
JS::GCPtr<JS::Script> m_script_record;
MutedErrors m_muted_errors { MutedErrors::No };
Optional<JS::Parser::Error> m_error_to_rethrow;
};