From 8fa334a70cae67cb8b6403584f2f1c1ac86b627d Mon Sep 17 00:00:00 2001 From: Ali Mohammad Pur Date: Fri, 18 Feb 2022 15:37:51 +0330 Subject: [PATCH] LibProtocol: Close the stream notifier unconditionally on EOF We shouldn't wait for on_finish to close the read notifier, we'll get the finished message when we do, no need to spin waiting for it. --- Userland/Libraries/LibProtocol/Request.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibProtocol/Request.cpp b/Userland/Libraries/LibProtocol/Request.cpp index bf506c2582..6fa59bad17 100644 --- a/Userland/Libraries/LibProtocol/Request.cpp +++ b/Userland/Libraries/LibProtocol/Request.cpp @@ -60,10 +60,11 @@ void Request::stream_into_impl(T& stream) } } while (true); - if (m_internal_stream_data->read_stream->is_eof() && m_internal_stream_data->request_done) { + if (m_internal_stream_data->read_stream->is_eof()) m_internal_stream_data->read_notifier->close(); + + if (m_internal_stream_data->request_done) m_internal_stream_data->on_finish(); - } }; }