RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:27:35 +00:00
Code Issues Activity Actions

LibSQL: Use absolute value when comparing against floating point epsilon

Browse source 
Otherwise, any value that is less than another value would be considered
about equal by mistake.
This commit is contained in:
Timothy Flynn 2022-02-10 17:56:17 -05:00 • committed by Linus Groh
parent e649ff5d31
commit 8fab99e920
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibSQL/Value.cpp
View file

@ -773,8 +773,11 @@ int FloatImpl::compare(Value const& other) const
if (!casted.has_value()) { if (!casted.has_value()) {
return 1; return 1;
} }
auto diff = value() - casted.value(); auto diff = value() - casted.value();
return (diff < NumericLimits<double>::epsilon()) ? 0 : ((diff > 0) ? 1 : -1); if (fabs(diff) < NumericLimits<double>::epsilon())
return 0;
return diff < 0 ? -1 : 1;
} }
String BooleanImpl::to_string() const String BooleanImpl::to_string() const