RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:02:46 +00:00
Code Issues Activity Actions

LibWeb: Port HTMLToken prefix and namespace to Optional<FlyString>

Browse source 
Previously these were DeprecatedStrings that contained a null state.
After the null state was removed, the nullability of these members was
broken. This doesn't seem to cause any problems currently as the HTML
parser is not inserting attributes with their full qualified name, but
after we fix that problem, this bug surfaces.
This commit is contained in:
Shannon Booth 2023-11-04 11:26:44 +13:00 • committed by Sam Atkins
parent fcde808308
commit 8fbf72b5bf
3 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -42,9 +42,9 @@ public:
};
struct Attribute {
DeprecatedString prefix;
Optional<FlyString> prefix;
FlyString local_name;
FlyString namespace_;
Optional<FlyString> namespace_;
String value;
Position name_start_position;
Position value_start_position;
@ -290,7 +290,7 @@ public:
});
}
void adjust_foreign_attribute(FlyString const& old_name, DeprecatedFlyString const& prefix, FlyString const& local_name, FlyString const& namespace_)
void adjust_foreign_attribute(FlyString const& old_name, Optional<FlyString> const& prefix, FlyString const& local_name, Optional<FlyString> const& namespace_)
{
VERIFY(is_start_tag() || is_end_tag());
for_each_attribute([&](Attribute& attribute) {