RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:07:46 +00:00
Code Issues Activity Actions

LibJS: Coerce named captures to an object before calling GetSubstitution

Browse source 
Per the spec, before invoking the GetSubstitution abstraction, the named
capture groups (if not undefined) should be coerced to an object via the
ToObject abstraction.
This commit is contained in:
Timothy Flynn 2021-07-06 09:06:49 -04:00 • committed by Linus Groh
parent 424c7eaa40
commit 8fcdc57ae1
2 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -399,7 +399,14 @@ JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::symbol_replace)
if (vm.exception())
return {};
} else {
replacement = get_substitution(global_object, matched, string, position, captures, named_captures, replace_value);
auto named_captures_object = js_undefined();
if (!named_captures.is_undefined()) {
named_captures_object = named_captures.to_object(global_object);
if (vm.exception())
return {};
}
replacement = get_substitution(global_object, matched, string, position, captures, named_captures_object, replace_value);
if (vm.exception())
return {};
}