RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:17:45 +00:00
Code Issues Activity Actions

LibJS: Fix a handful of clang-tidy complaints in AST.cpp

Browse source
This commit is contained in:
Andreas Kling 2021-03-03 22:07:10 +01:00
parent 0fc3983c8d
commit 8fd69e9e56
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/AST.cpp
View file

@ -207,11 +207,11 @@ Value CallExpression::execute(Interpreter& interpreter, GlobalObject& global_obj
MarkedValueList arguments(vm.heap()); MarkedValueList arguments(vm.heap());
arguments.ensure_capacity(m_arguments.size()); arguments.ensure_capacity(m_arguments.size());
for (size_t i = 0; i < m_arguments.size(); ++i) { for (auto& argument : m_arguments) {
auto value = m_arguments[i].value->execute(interpreter, global_object); auto value = argument.value->execute(interpreter, global_object);
if (vm.exception()) if (vm.exception())
return {}; return {};
if (m_arguments[i].is_spread) { if (argument.is_spread) {
get_iterator_values(global_object, value, [&](Value iterator_value) { get_iterator_values(global_object, value, [&](Value iterator_value) {
if (vm.exception()) if (vm.exception())
return IterationDecision::Break; return IterationDecision::Break;
@ -717,7 +717,7 @@ Value UnaryExpression::execute(Interpreter& interpreter, GlobalObject& global_ob
} }
// FIXME: standard recommends checking with is_unresolvable but it ALWAYS return false here // FIXME: standard recommends checking with is_unresolvable but it ALWAYS return false here
if (reference.is_local_variable() || reference.is_global_variable()) { if (reference.is_local_variable() || reference.is_global_variable()) {
auto name = reference.name(); const auto& name = reference.name();
lhs_result = interpreter.vm().get_variable(name.to_string(), global_object).value_or(js_undefined()); lhs_result = interpreter.vm().get_variable(name.to_string(), global_object).value_or(js_undefined());
if (interpreter.exception()) if (interpreter.exception())
return {}; return {};
@ -804,7 +804,7 @@ Value ClassExpression::execute(Interpreter& interpreter, GlobalObject& global_ob
update_function_name(class_constructor_value, m_name); update_function_name(class_constructor_value, m_name);
VERIFY(class_constructor_value.is_function() && is<ScriptFunction>(class_constructor_value.as_function())); VERIFY(class_constructor_value.is_function() && is<ScriptFunction>(class_constructor_value.as_function()));
ScriptFunction* class_constructor = static_cast<ScriptFunction*>(&class_constructor_value.as_function()); auto* class_constructor = static_cast<ScriptFunction*>(&class_constructor_value.as_function());
class_constructor->set_is_class_constructor(); class_constructor->set_is_class_constructor();
Value super_constructor = js_undefined(); Value super_constructor = js_undefined();
if (!m_super_class.is_null()) { if (!m_super_class.is_null()) {