From 8fdf4b43cd4b9e1fd3a3bab9a8648be2261f28b1 Mon Sep 17 00:00:00 2001
From: Luke Wilde <lukew@serenityos.org>
Date: Fri, 28 Oct 2022 06:00:58 +0100
Subject: [PATCH] LibWasm: Specify which instruction opcode failed validation
 in error

---
 Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp b/Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp
index 56cba381e0..830fc7c931 100644
--- a/Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp
+++ b/Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp
@@ -318,9 +318,9 @@ ErrorOr<void, ValidationError> Validator::validate(Limits const& limits, size_t
 }
 
 template<u32 opcode>
-ErrorOr<void, ValidationError> Validator::validate_instruction(Instruction const&, Stack&, bool&)
+ErrorOr<void, ValidationError> Validator::validate_instruction(Instruction const& instruction, Stack&, bool&)
 {
-    return Errors::invalid("instruction opcode"sv);
+    return Errors::invalid(String::formatted("instruction opcode (0x{:x}) (missing validation!)", instruction.opcode().value()));
 }
 
 #define VALIDATE_INSTRUCTION(name) \
@@ -2179,7 +2179,7 @@ ErrorOr<void, ValidationError> Validator::validate(Instruction const& instructio
 #undef M
     default:
         is_constant = false;
-        return Errors::invalid("instruction opcode"sv);
+        return Errors::invalid(String::formatted("instruction opcode (0x{:x})", instruction.opcode().value()));
     }
 }