mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 23:17:44 +00:00
LibJS: Throw in strict mode when assigning property to primitive value
This commit is contained in:
parent
5f2632f121
commit
8ff4587f65
3 changed files with 25 additions and 5 deletions
|
@ -559,15 +559,12 @@ Reference Identifier::to_reference(Interpreter& interpreter) const
|
||||||
Reference MemberExpression::to_reference(Interpreter& interpreter) const
|
Reference MemberExpression::to_reference(Interpreter& interpreter) const
|
||||||
{
|
{
|
||||||
auto object_value = m_object->execute(interpreter);
|
auto object_value = m_object->execute(interpreter);
|
||||||
if (object_value.is_empty())
|
if (interpreter.exception())
|
||||||
return {};
|
|
||||||
auto* object = object_value.to_object(interpreter);
|
|
||||||
if (!object)
|
|
||||||
return {};
|
return {};
|
||||||
auto property_name = computed_property_name(interpreter);
|
auto property_name = computed_property_name(interpreter);
|
||||||
if (!property_name.is_valid())
|
if (!property_name.is_valid())
|
||||||
return {};
|
return {};
|
||||||
return { object, property_name };
|
return { object_value, property_name };
|
||||||
}
|
}
|
||||||
|
|
||||||
Value UnaryExpression::execute(Interpreter& interpreter) const
|
Value UnaryExpression::execute(Interpreter& interpreter) const
|
||||||
|
|
|
@ -50,6 +50,11 @@ void Reference::put(Interpreter& interpreter, Value value)
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!base().is_object() && interpreter.in_strict_mode()) {
|
||||||
|
interpreter.throw_exception<TypeError>(String::format("Can't assign property %s to primitive value", m_name.to_string().characters()));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
auto* object = base().to_object(interpreter);
|
auto* object = base().to_object(interpreter);
|
||||||
if (!object)
|
if (!object)
|
||||||
return;
|
return;
|
||||||
|
|
18
Libraries/LibJS/Tests/strict-mode-errors.js
Normal file
18
Libraries/LibJS/Tests/strict-mode-errors.js
Normal file
|
@ -0,0 +1,18 @@
|
||||||
|
"use strict";
|
||||||
|
|
||||||
|
load("test-common.js")
|
||||||
|
|
||||||
|
try {
|
||||||
|
[true, false, "foo", 123].forEach(primitive => {
|
||||||
|
assertThrowsError(() => {
|
||||||
|
primitive.foo = "bar";
|
||||||
|
}, {
|
||||||
|
error: TypeError,
|
||||||
|
message: "Can't assign property foo to primitive value"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
console.log("PASS");
|
||||||
|
} catch (e) {
|
||||||
|
console.log("FAIL: " + e);
|
||||||
|
}
|
Loading…
Add table
Add a link
Reference in a new issue