RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:57:44 +00:00
Code Issues Activity Actions

LibWeb: Remove StringBuilders from HTMLToken::AttributeBuilder

Browse source
This commit is contained in:
Gunnar Beutner 2021-05-23 08:50:48 +02:00 • committed by Andreas Kling
parent 992964aa7d
commit 901d71148b
4 changed files with 41 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -106,8 +106,8 @@ public:
{
VERIFY(is_start_tag() || is_end_tag());
for (auto& attribute : m_tag.attributes) {
if (attribute_name == attribute.local_name_builder.string_view())
return attribute.value_builder.string_view();
if (attribute_name == attribute.local_name)
return attribute.value;
}
return {};
}
@ -130,9 +130,8 @@ public:
{
VERIFY(is_start_tag() || is_end_tag());
for (auto& attribute : m_tag.attributes) {
if (old_name == attribute.local_name_builder.string_view()) {
attribute.local_name_builder.clear();
attribute.local_name_builder.append(new_name);
if (old_name == attribute.local_name) {
attribute.local_name = new_name;
}
}
}
@ -141,12 +140,9 @@ public:
{
VERIFY(is_start_tag() || is_end_tag());
for (auto& attribute : m_tag.attributes) {
if (old_name == attribute.local_name_builder.string_view()) {
if (old_name == attribute.local_name) {
attribute.prefix = prefix;
attribute.local_name_builder.clear();
attribute.local_name_builder.append(local_name);
attribute.local_name = local_name;
attribute.namespace_ = namespace_;
}
}
@ -179,9 +175,9 @@ private:
struct AttributeBuilder {
String prefix;
StringBuilder local_name_builder;
String local_name;
String namespace_;
StringBuilder value_builder;
String value;
Position name_start_position;
Position value_start_position;
Position name_end_position;