RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:27:35 +00:00
Code Issues Activity Actions

WebContent: Tolerate invalid page_ids in ConnectionFromClient

Browse source 
When a tab or nested traversable navigable is closed, there might be
messages still in the pipe from the UI process that we need to
gracefully drop, rather than crash trying to access an invalid pointer.
This commit is contained in:
Andrew Kaster 2024-02-12 17:39:20 -07:00 • committed by Andreas Kling
parent 3d6c515bae
commit 9077fe15ac
4 changed files with 417 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WebContent/ConnectionFromClient.h
View file

@ -44,8 +44,8 @@ public:
private:
explicit ConnectionFromClient(NonnullOwnPtr<Core::LocalSocket>);
PageClient& page(u64 index);
PageClient const& page(u64 index) const;
Optional<PageClient&> page(u64 index);
Optional<PageClient const&> page(u64 index) const;
virtual Messages::WebContentServer::GetWindowHandleResponse get_window_handle(u64 page_id) override;
virtual void set_window_handle(u64 page_id, String const& handle) override;